Summary: | malformed patches are silently cut off | ||
---|---|---|---|
Product: | [Applications] kompare | Reporter: | Chani <chanika> |
Component: | general | Assignee: | Kompare developers <kompare-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Unspecified | ||
Latest Commit: | Version Fixed In: |
Description
Chani
2010-04-27 00:57:50 UTC
As discussed on IRC, patch errors out on this with "patch: **** malformed patch at line 15: …", I think this is the behavior we'll want to match more or less. What I suggested on IRC is that we still display what we can, but pop up a KMessageBox complaining about the malformed patch. I'm taking care of this now, given the impending message freeze. SVN commit 1128360 by kkofler: Kompare: Detect malformed diffs and display an error message to the user in that case. Still display what we can display, but tell the user that some lines will be missing. Tested on Fedora 12, kdelibs 4.4.2. BUG: 235503 M +8 -1 komparemodellist.cpp M +3 -2 parser.cpp M +2 -1 parser.h M +35 -8 parserbase.cpp M +4 -1 parserbase.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1128360 |