Summary: | openURL(const KUrl& url) doesn't load url if the session is already started | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Jan Gerrit Marker <jangerrit> |
Component: | kpart | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED DUPLICATE | ||
Severity: | normal | CC: | adaptee, akreuzkamp |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | A small patch |
Description
Jan Gerrit Marker
2010-04-18 14:15:20 UTC
Created attachment 42873 [details]
A small patch
Your patch has some issues: -In most usecases you don't want the konsole to clear, but with your patch does this (so you should delete the line "sendInput("clear\n");") -I don't see the sense of the lines QString cancel; till sendInput(cancel); I only see it writing ^C without any result, so I think these lines could also be deleted 1) the first issue is ok, the maintainer(s) of Konsolepart should decide, I did this to prevent the user from seeing "^C" 2) in Dolphin this is done to prevent from an accidently execution, an example: $~>rm -rf * ; now the change directory command is added: $~>rm -rf * ; cd / <ENTER> and all files in the $HOME are removed, but maybe the user wanted to remove the command but the programm which owns the part was faster and changed the directory. I'd say that this is important. This patch is only a representation of an idea to fix this based on the Dolphin way of doing this. Actually I've been meaning to do this for the bookmarks. There is another bko for clearing the command line before doing the bookmark. I think the ^C is a good option to clear the command line. So, the real problem is showShellInDir() is broken, which is called within openURL(). *** This bug has been marked as a duplicate of bug 225857 *** |