| Summary: | Red eye correction tool is missing from image editor | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andreas Tiemeyer <grey271> |
| Component: | Faces-RedEyes | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, SanskritFritz, seandarcy |
| Priority: | NOR | ||
| Version: | 1.2.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.3.0 | |
| Sentry Crash Report: | |||
| Attachments: | corrected name for redeye plugin | ||
|
Description
Andreas Tiemeyer
2010-04-16 17:36:12 UTC
Not reproducible there. Sound like a packaging issue. please start digiKam from a console and post there all debug messages. note : install digikam-debug package before... Gilles Caulier Created attachment 42832 [details]
corrected name for redeye plugin
Comment on attachment 42832 [details]
corrected name for redeye plugin
The problem seems to be that the name of the redeye plugin is not the same in the _rc.ui file and the c++ code.
However: if this is the root cause, the bug should be reproducible every time on the released sources. So I don't understand how it counld not be reproduced.
This problem will must be fixed in 1.3.0 (code from svn trunk). I factored image plugins to speed up startup. Can you checkout code from svn trunk and confirm please ? Gilles Caulier I can confirm that the patch works, I recompiled digikam 1.2 with the patch applied, and redeye correction is back. Thank you. (In reply to comment #4) > > Can you checkout code from svn trunk and confirm please ? > > Gilles Caulier > That pulls in too many dependencies - I'd have to rebuild kdegraphics from svn as well according to the package information of my distribution, which I usually trust. I don't think it's worth it - this isn't a bug that depends on the environment. If it works for you on the trunk sources, it will work for me. The functionality is still there, the item is just missing from the Enhance menu. Instead of recompiling and applying a patch you can try adding a custom "Red Eye" button to the toolbar. http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981 I'm using digikam and kipi-plugins from svn today: At revision 1118351. There's no red eye correction tool in the Enhance menu. sean Just tried the steps from http://bbs.archlinux.org/viewtopic.php?pid=744981#p744981. That had no effect. In fact, it didn't change the Enhance drop down menu for any item if I changed it. sean, if you read it more carefully, you will see it changes the toolbar and not the menu. I'm in Image Editor. I see 3 toolbars: Top: File Edit View Color etc Just below Top: First Back Forward etc Bottom: <filename> No selection <w x h> etc I don't see Red Eye anywhere. Am I looking in the wrong place? sean Right click on the toolbar / Configure toolbars / Toolbar: digikamimageplugin_enhance / highlight Red Eye in the list below / Click the right arrow to transfer it to the right side / Ok. SVN commit 1118552 by cgilles: use right name for Red eyes tool action BUGS: 234545 M +2 -2 digikamimageplugin_enhance_ui.rc M +1 -1 imageplugin_enhance.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1118552 |