Summary: | Capacity gauge is not updated after copying files to iPod & MTP | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Hakan Bayindir <hakan> |
Component: | Collections/Media Devices | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aumuell, bart.cerneels, manu.wagner, matej, mrudolf, pastas4 |
Priority: | NOR | ||
Version: | 2.4.3 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.5 |
Description
Hakan Bayindir
2010-03-25 11:17:03 UTC
Isn't that the same as bug 231827? Unfortunately no. bug 231827 is about deletion of songs from iPod. This happens when uploading. When deleting: Neither count, nor capacity gauge changes When adding : Count changes but capacity gauge not. Cheers. *** Bug 236485 has been marked as a duplicate of this bug. *** This ticket is also valid for Amarok 2.3.0.90 (2.3.1 Beta 1). This is an automated message from the triager: Amarok 2.4.1 has been released on May 8 already. Could you please upgrade and test if you can still reproduce this bug? Without feedback within a month we will close this bug as resolved. Thank you for your understanding. Closing for lack of feedback. Feel free to reopen if you can still reproduce this with Amarok 2.4.2 beta 1 or later and provide the necessary feedback. Confirmed, this still happens on Amarok 2.4.3, with slight differences: it does update the first track that is uploaded, but not any of the subsequent ones, and neither the count nor the size gauge changes then, although the tracks are shown under the device properly. This happens on openSUSE 11.4, tested using iRiver T10a MTP device. Thank you for the feedback. Note that this is *not* specific to the iPod - as I noted, I am using an iRiver MTP device here. iPod & MTP only as it's fixed for USB Mass Storage. I'm working on the iPod part of this. Git commit 94a92530f2ab7f8acef6715659c78b14bc263428 by Matěj Laitl. Committed on 04/12/2011 at 23:00. Pushed by laitl into branch 'master'. MediaDeviceCollection: do not cache used capacity w/out update mechanism Relevant media device handler should do this caching, and even without it, the calls aren't that expensive. Solves first part of bug 232093, second part (that deals with track count) will follow shortly. CCBUG: 232093 M +2 -16 src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.cpp M +0 -5 src/core-impl/collections/mediadevicecollection/MediaDeviceCollection.h M +0 -2 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp http://commits.kde.org/amarok/94a92530f2ab7f8acef6715659c78b14bc263428 Git commit 43d000e2dd20795c514d8124a615ecfeb7377e49 by Matěj Laitl. Committed on 04/12/2011 at 23:17. Pushed by laitl into branch 'master'. Fix completely bogus MediaDeviceHandler::removeMediaDeviceTrackFromColl That method did not work _at all_ because it used wrong key in the trackMap forgot to actually write back other maps. :-) As a result, dead tracks were never removed from memory collection and thus the count was not updated, among other (worse) things. BUG: 232093 FIXED-IN: 2.5 DIGEST: Capacity gauge is now always updated for iPods & MTP devices M +2 -0 ChangeLog M +11 -8 src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp http://commits.kde.org/amarok/43d000e2dd20795c514d8124a615ecfeb7377e49 |