Bug 229465

Oh, it should be "...There is no error message and no CRASH...". Sorry...

Confirmed using 4.4.0 on XP PRO SP3

This bug exists also on Win7 64 bit and KDE version 4.4.4 (Dolphin version 1.4).

*** Bug 235621 has been marked as a duplicate of this bug. ***

*** Bug 235594 has been marked as a duplicate of this bug. ***

It's the same problem under windows 7 with current implementation of digiKam 1.6.0

item deletion is delegate to KIO of course :

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/dio.cpp#162

Gilles Caulier

Created attachment 52937 [details]
digiKam windows file delete 01

Created attachment 52938 [details]
digiKam windows file delete 02

For me this bug is relevant of KIO, not Dolphin, as it can be reproduced into digiKam and also konqueror (just tested)

Gilles Caulier

Very interresting point. If i drag and Drop an item from digiKam icon view to windows Trash icon, all work fine !!!

Gilles Caulier

Just tested with Dolphin too : to drag and drop an item from icon view to windows trash icon work fine !

Gilles Caulier

I set priority to MAJOR, because KDE application lost an important and common feature...

Gilles Caulier

Here i tested under XP, VISTA, and WIN7 using KDE 4.4.4 for windows. Same problem.

KDE 4.5.x is not avaialble under windows. I cannot check with this release.

Gilles Caulier

Using my built from source, KDE 4.5.70 as reported by digikam, this bug is still present. XP 32 bit.

*** Bug 261471 has been marked as a duplicate of this bug. ***

There is nothing news in this file ?  Nobody have take a look about this problem. It's a major bug under windows...

Gilles Caulier

*** Bug 274733 has been marked as a duplicate of this bug. ***

Created attachment 61208 [details]
error dialog with digiKam 2.0.0 rc compiled with MSVC 2008

See the trace from DebugView when file is sent to trash :


[1152] digikam(1152)/digikam (core) void __thiscall Digikam::DeleteDialog::slotUser1Clicked(void): setShowTrashDeleteDialog  true
[1152] digikam(1152)/digikam (core) class KIO::Job *__cdecl Digikam::DIO::del(const class KUrl::List &,bool): Files to delete :  (KUrl("digikamalbums:/papillons/DSC02087.ARW?albumRoot=D%3A%2FPhotos&albumRootId=1&databaseType=QSQLITE&databaseName=C%3A%2FUsers%2FGilles%2FPictures%2Fdigikam4.db&connectOptions=&hostName=&userName=&password=") )
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::doJob(class KIO::SimpleJob *): KIO::SimpleJob(0x176a4de8)
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::jobFinished(class KIO::SimpleJob *,class KIO::Slave *): KIO::StatJob(0x176a4de8) KIO::Slave(0x173acd40)
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::doJob(class KIO::SimpleJob *): KIO::SimpleJob(0x176a4d40)
[1204] Debug:kio_digikamalbums(1204)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::doJob(class KIO::SimpleJob *): KIO::SimpleJob(0x298f778)
[4292] Debug:kio_file(4292) void __thiscall FileProtocol::stat(const class KUrl &): FileProtocol::stat details= 2
[1204] Debug:kio_digikamalbums(1204)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::jobFinished(class KIO::SimpleJob *,class KIO::Slave *): KIO::StatJob(0x298f778) KIO::Slave(0x29a7510)
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::jobFinished(class KIO::SimpleJob *,class KIO::Slave *): KIO::StatJob(0x176a4d40) KIO::Slave(0x1397fbb8)
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::doJob(class KIO::SimpleJob *): KIO::SimpleJob(0x176a5dd8)
[1152] digikam(1152)/KEXIV2 void __cdecl KExiv2Iface::KExiv2::KExiv2Priv::printExiv2MessageHandler(int,const char *): Exiv2 ( 3 ) :  Offset of directory Sony1, entry 0x2001 is out of bounds: Offset = 0x0029005e; truncating the entry
[1152] digikam(1152)/KEXIV2 enum KExiv2Iface::KExiv2::ImageOrientation __thiscall KExiv2Iface::KExiv2::getImageOrientation(void) const: Orientation => Exif.Image.Orientation =>  1
[4148] Debug:kio_trash(4148) void __thiscall TrashProtocol::put(const class KUrl &,int,class QFlags<enum KIO::JobFlag>): put:  KUrl("trash:/DSC02087.ARW")
[1152] digikam(1152)/kio (KIOJob) bool __thiscall KIO::SlaveInterface::dispatch(int,const class QByteArray &): error  115   "trash:/DSC02087.ARW"
[1152] digikam(1152)/kio (KIOJob) void __thiscall KIO::TransferJob::slotFinished(void): KUrl("trash:/DSC02087.ARW")
[1152] digikam(1152)/kio (Scheduler) void __thiscall KIO::SchedulerPrivate::jobFinished(class KIO::SimpleJob *,class KIO::Slave *): KIO::TransferJob(0x176a5dd8) KIO::Slave(0x173acd40)

Gilles Caulier

Note that with MSVC, there is no crash, just an error dialog who said that it's not permit to access on trash:/

The question is WHY ? Thereis something to patch in windows registery to permit to use trash with an application ?

Gilles Caulier

Julien,

perhaps there is something to do with NSIS installer to give right to digiKam or KDE KIO slave to write on windows trash ?

Gilles Caulier

See this relevant file for info :

https://bugs.kde.org/show_bug.cgi?id=166280

Gilles Caulier

Link on #6 is broken since code is moved to git. new link is here :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/digikam/database/dio.cpp#L143

Gilles Caulier

Git commit 9d025212a78237a48308a691cb1448ce3703b4e4 by Patrick Spendrin.
Committed on 06/03/2012 at 14:16.
Pushed by sengels into branch 'KDE/4.8'.

fix moving files from and to the trash

M  +1    -2    kioslave/trash/kio_trash_win.cpp

http://commits.kde.org/kde-runtime/9d025212a78237a48308a691cb1448ce3703b4e4

Git commit bc601710c069181e5bdf3a7214b8b7942a407ff4 by Patrick Spendrin.
Committed on 06/03/2012 at 14:16.
Pushed by sengels into branch 'master'.

fix moving files from and to the trash
(cherry picked from commit 9d025212a78237a48308a691cb1448ce3703b4e4)

M  +1    -2    kioslave/trash/kio_trash_win.cpp

http://commits.kde.org/kde-runtime/bc601710c069181e5bdf3a7214b8b7942a407ff4

Excelent. Thanks Patrick to fix this old and very annoying bug. 
Which version of KDE for windows will include these fixes ?

Ananta, 

Can you confirm that bug is fixed with digiKam ?

Gilles Caulier

(In reply to comment #26)
> Excelent. Thanks Patrick to fix this old and very annoying bug. 
> Which version of KDE for windows will include these fixes ?
> 
> Ananta, 
> 
> Can you confirm that bug is fixed with digiKam ?
> 
> Gilles Caulier

Gilles,

I believe this Patrick said this patch will be in 4.8.1, so when it is released I will try it out and let you know.

-Ananta