Bug 229425

Summary:	[PATCH] kget does not compile in trunk
Product:	[Applications] kget	Reporter:	Christoph Feck <cfeck>
Component:	torrent	Assignee:	KGet authors <kget>
Status:	RESOLVED FIXED
Severity:	normal	CC:	robert
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Proposed patch

Description Christoph Feck 2010-03-04 18:48:30 UTC

Version:            (using Devel)
Installed from:    Compiled sources

Due to the removal of the SVN external for libbtcore, kget no longer compiles with torrent support enabled.

The attached patch fixes compilation, but I cannot verify its correctness; it has been deduced from the changes made to that library during the time.

So please do not apply without someone in the know having a deep look at it. Thanks!

Comment 1 Christoph Feck 2010-03-04 18:49:21 UTC

Created attachment 41333 [details]
Proposed patch

Comment 2 Lukas Appelhans 2010-03-04 19:42:42 UTC

Well the problem are different versions of libbtcore installed I think... which one do you have? trunk or latest stable-branch? (which would be the one it should compile with...)

Comment 3 Christoph Feck 2010-03-04 19:50:23 UTC

I only use trunk.

Comment 4 Lukas Appelhans 2010-03-04 20:06:43 UTC

Yes, I should add a version check...

Lukas

Comment 5 Lukas Appelhans 2010-03-05 12:56:19 UTC

*** Bug 229480 has been marked as a duplicate of this bug. ***

Comment 6 Robert Marmorstein 2010-03-05 13:36:26 UTC

Sorry I missed this.  I tried to search for something like it, but didn't get all the right keywords.

From looking at the libbtcore source in extragear/ktorrent it seems to me that isOk() and isTCPEnabled() are not the same function.  Instead, the isOk() function was included into the "initTCPServer()" function which now returns bool instead of void.  The patch I provided to the duplicate bug tries to use that functionality instead of isTCPEnabled().  Perhaps I'm mistaken, though...

Comment 7 Christoph Feck 2010-03-05 13:41:30 UTC

Comment on attachment 41333 [details]
Proposed patch

Right, I just made sure it compiles, see the warning above. I will invalidate this patch, since yours from bug 229480 is better.

Comment 8 Lukas Appelhans 2010-03-05 13:49:33 UTC

Well as I commented on the other bug already, we depend on the stable-branched version, which is NOT extragear/network/ktorrent/libbtcore... (I should add version-checks)

Anyway, a real fix might come soon as libbtcore is going to get split out of ktorrent even more, so it will be a "proper" library...

Lukas

Comment 9 Christoph Feck 2010-04-25 14:57:42 UTC

A proper patch has been committed, so this can be closed.

Comment 10 Lukas Appelhans 2010-04-25 17:18:14 UTC

Yes... let's do it...

Lukas