| Summary: | kde menu editor, move item doesn't work | ||
|---|---|---|---|
| Product: | [Applications] kmenuedit | Reporter: | Rufus Laggren <rufusl2001> |
| Component: | general | Assignee: | Unassigned bugs mailing-list <unassigned-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | annma, maris.kde, nzlbob2332, opensource, P.Suetterlin, roland.leissa, superaphke, Wolfram.R.Sieber |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Rufus Laggren
2010-02-20 18:36:26 UTC
KDE Menu Editor still totally buggy in KDE SC 4.4.1 duplicate of https://bugs.kde.org/show_bug.cgi?id=99420 ? Confirmed but this product has no maintainer... Possibly related bugs: #229665 #102723 #110241 #186683 #221259 #110565 #93923 #102349 #219854 #186683 I compared KMenuedit 0.7 running 3.5.10 and 0.8 running 4.4.1 output in .config/menu/applications-kmenuedit.menu after performing following steps:
mv applications-kmenuedit.menu /some/other/place
launch KMenuedit
Move "Games" folder to "Utilities"
<Move>
- <Old>Games</Old>
- <New>Utilities/Games</New>
+ <Old>Games/</Old>
+ <New>Utilities/Games/</New>
</Move>
After I removed tailing / from Games, folder got moved in Kickoff too.
Workaround for all - open .config/menu/applications-kmenuedit.menu with kate and check for:
1) tailing / at end of folder names;
2) folder names ending with -2 or -1. Delete <move> blocks with "foldername-2" and fix any references to "foldername-2" to point to real name ("foldername").
If someone has the source and can try the following patch: it fixes the trailing / (so it fixes the moving of folders when there is not the same named folder in the moved folder)
Index: menufile.cpp
===================================================================
--- menufile.cpp (revision 1105524)
+++ menufile.cpp (working copy)
@@ -408,14 +408,14 @@
commonMenuName += '/' + oldMenuParts[i];
}
QString oldMenuName;
- for(int j = i; j < oldMenuParts.count(); j++)
+ for(int j = i; j < oldMenuParts.count()-1; j++)
{
if (i != j)
oldMenuName += '/';
oldMenuName += oldMenuParts[j];
}
QString newMenuName;
- for(int j = i; j < newMenuParts.count(); j++)
+ for(int j = i; j < newMenuParts.count()-1; j++)
{
if (i != j)
newMenuName += '/';
*** Bug 229665 has been marked as a duplicate of this bug. *** *** Bug 102723 has been marked as a duplicate of this bug. *** *** Bug 110241 has been marked as a duplicate of this bug. *** *** Bug 186683 has been marked as a duplicate of this bug. *** Anyone tried the patch? What are the other obvious bugs with KMenuEdit in KDE 4.4? (In reply to comment #11) > Anyone tried the patch? > > What are the other obvious bugs with KMenuEdit in KDE 4.4? AFAIK no. Could You, please, reformat patch as file in form suitable to apply directly to 4.4.1 release tarball? I have no idea where this "menu.cpp" file is located, still I can define a patch to apply after unpacking application and before compiling it (Gentoo here). menufile.cpp is in kdebase/workspace/kmenuedit/ and the patch is to be applied in that directory against 4.4.1 sources. I'll be away for 1 week starting tomorrow until 29 March evening without internet! (In reply to comment #11) > Anyone tried the patch? > This patch works. After recompiling with this patch, moving folders in KMenuedit works just fine and generated .menu file is correct. SVN commit 1108974 by annma: Move folders correctly. Thanks a lot Maris for all the investigation and the patch testing, it's very nice of you having taken the time to research this bug! BUG=227836 M +2 -2 menufile.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1108974 SVN commit 1110017 by annma: also in trunk! CCBUG=227836 M +2 -2 menufile.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1110017 |