Bug 226984

Summary: Clicking on e-mail address of contact with non-latin name opens Composer with ??? as the recipient name
Product: [Applications] kaddressbook Reporter: Vasileios P. Lourdas <bugzilla>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED WORKSFORME    
Severity: normal CC: hr.denzler, kde-2011.08, m.wege, snvv101, tokoe
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Addressbook with non-latin contact names
Composer window with ???? as contact name
utf8 encoded recipient name
utf8 encoded recipient name

Description Vasileios P. Lourdas 2010-02-15 13:01:43 UTC
Version:            (using KDE 4.4.0)
Compiler:          gcc 4.4.3 gcc (Gentoo 4.4.3 p1.0) 4.4.3
OS:                Linux
Installed from:    Gentoo Packages

I have my address book with contacts that have names with non-latin characters, in fact they are Greek. With KAddressbook open, clicking on the contact's e-mail opens Composer, but instead of displaying "contact's name" <e-mail address> in the recipient, it displays "??????" <e-mail address>.

I will attach screenshots.
Comment 1 Vasileios P. Lourdas 2010-02-15 13:05:30 UTC
Created attachment 40798 [details]
Addressbook with non-latin contact names
Comment 2 Vasileios P. Lourdas 2010-02-15 13:06:11 UTC
Created attachment 40799 [details]
Composer window with ???? as contact name
Comment 3 Thomas McGuire 2010-03-04 19:18:05 UTC
*** Bug 229382 has been marked as a duplicate of this bug. ***
Comment 4 Thomas McGuire 2010-03-04 19:21:32 UTC
SVN commit 1098945 by tmcguire:

Use the new encoding function for mailto URLs instead of trying to encode it
ourselves, as that will fail since it was missing RFC2047-encoding

BUG: 226984


 M  +2 -0      CMakeLists.txt  
 M  +2 -4      contactdefaultactions.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1098945
Comment 5 Thomas McGuire 2010-04-27 11:39:20 UTC
*** Bug 235439 has been marked as a duplicate of this bug. ***
Comment 6 Nicolas L. 2010-04-27 12:07:51 UTC
SVN commit 1119520 by nlecureuil:

Backport revisions 1098941 and 1098945
CCBUG: 226984



 M  +2 -0      akonadi/contact/CMakeLists.txt  
 M  +2 -3      akonadi/contact/contactdefaultactions.cpp  
 M  +16 -0     kpimutils/email.cpp  
 M  +20 -0     kpimutils/email.h  
 M  +14 -0     kpimutils/tests/testemail.cpp  
 M  +1 -0      kpimutils/tests/testemail.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1119520
Comment 7 Vasileios P. Lourdas 2010-05-09 21:41:11 UTC
I'm reopening the bug, since in current version 4.4.3 of KDE (Gentoo packages), the problem is not fixed and the behavior is now different. Clicking on the e-mail address, a new Composer window opens with the name of the recipient as utf-8 encoded (or something like that). See the attached screenshot.
Comment 8 Vasileios P. Lourdas 2010-05-09 21:41:42 UTC
Created attachment 43410 [details]
utf8 encoded recipient name
Comment 9 Vasileios P. Lourdas 2010-05-09 21:44:45 UTC
Created attachment 43411 [details]
utf8 encoded recipient name
Comment 10 snvv101 2010-05-10 00:00:12 UTC
I confirm that bug in  KDE 4.4.3 using Debian sid.
Comment 11 Hans-Rudi Denzler 2010-05-10 09:59:00 UTC
In openSUSE 11.2:
The "To:"-field is now empty if the name field has "ü".
Comment 12 Tobias Koenig 2010-05-21 16:33:06 UTC
Hej,

you must have tested it with a version that doesn't contain the commit from comment #6. I can't reproduce the described behavior here neither with the current version from 4.4 branch nor with SVN trunk. I have tested with greek characters and german umlauts, in both cases the name and the email addresses show up correctly inside the mail composer.
Comment 13 Vasileios P. Lourdas 2010-05-21 17:47:41 UTC
(In reply to comment #12)
> Hej,
> 
> you must have tested it with a version that doesn't contain the commit from
> comment #6. I can't reproduce the described behavior here neither with the
> current version from 4.4 branch nor with SVN trunk. I have tested with greek
> characters and german umlauts, in both cases the name and the email addresses
> show up correctly inside the mail composer.

Hi Tobias.

I've just checked my distribution's package to see if it contains the patch in comment #6 and it does. I thought version 4.4.3 already contains this patch and since I'm not the only user experience this issue, then something else must be broken.

Tell me if I can provide more information.
Comment 14 Hans-Rudi Denzler 2010-05-21 18:11:33 UTC
KDE 4.4.3, openSUSE 11.2:
Try this one in kaddressbook:
1. Name: Thomas Rüedi
then
2. Name: Thomas Rüedi-Huser

click E-Mail address:
1. OK
2. To-Field is empty
Comment 15 Thomas McGuire 2010-06-11 13:04:32 UTC
Sorry, no time to look into this right now.
Comment 16 Vasileios P. Lourdas 2010-06-20 21:54:25 UTC
You can also take a look at bug #242231.
Comment 17 Tobias Koenig 2010-07-06 15:00:38 UTC
Hej,

I have committed a fix for this issue now to 4.5 branch and trunk.
Can you please all try whether it works for you?

Ciao,
Tobias
Comment 18 Tobias Koenig 2010-07-06 15:01:39 UTC
*** Bug 242614 has been marked as a duplicate of this bug. ***
Comment 19 Hans-Rudi Denzler 2010-07-06 18:02:45 UTC
test cases: (KDE 4.4.4, openSUSE 11.2)

Name:       --> To-field:
1. a ü -a   --> "a ü -a" <...>
2. a ü-a    --> empty
3. ü -a     --> empty
4. ü-a      --> ""ü-a"" <...>
Comment 20 Tobias Koenig 2010-07-06 20:54:59 UTC
Hej Hans-Rudi,

your test cases all pass here now with trunk and 4.5 branch.
Thank you very much for providing them!

Ciao,
Tobias