| Summary: | Device notifier window too small hides the mount/umount button | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | mickael.chazaux |
| Component: | widget-devicenotifier | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | Julius-Caesar, shaola, wilderkde |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
A screenshot showing the problem
snapshot spanish translation |
||
Created attachment 41322 [details]
A screenshot showing the problem
Still present in 4.4.1. With default font settings (size 9), it is OK, but with size 11, the button starts to disappear. Created attachment 43358 [details]
snapshot spanish translation
(In reply to comment #3) > Created an attachment (id=43358) [details] > snapshot spanish translation The same issue with spanish translation, happenning in kde 4.4.3 debian package. The description made in the first report matches perfectly with spansish translation issue I have same problem, this is my system: - Debian Sid, KDE 4.4.3, spanish localization. Only setting the localization to english and fonts size to the default of 9 pixels can see it correctly. if have noticed that the problem does not appear only with some translations. I think that the position of the button, depends not only on the size of the plasmoid, because when the plasmoid is smaller than the lengh of the text of the mainlabel, the button is alligned right and bellow the last letter of the text This also happens even when it's in english with low resolutions and/or too big font sizes. I've been reading the code of the plasmoid trying to underestand it in order to learn how to make some changes to make the button appear always inside the plasmoid no matter how long the length of the text in the "m_mainlabel" is, however i am a newbie in this matters. The only thing i found is this: "category->setAlignment(Qt::AlignRight);" by the way why AlignRight? if you see the https://bugs.kde.org/attachment.cgi?id=43358 i think that the label with the description of the device "Volumen de almacenamiento" aligned right is not the best option. cheers! SVN commit 1129215 by jacopods: Minimum sizes are evil, evil, evil! BUG:226710 M +2 -1 notifierdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1129215 SVN commit 1129216 by jacopods: Backport r1129215 CCBUG:226710 M +2 -1 notifierdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1129216 SVN commit 1130858 by jacopods: Better fix, this actually works. CCBUG:226710 M +2 -2 notifierdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1130858 SVN commit 1130862 by jacopods: Cleaner fix CCBUG:226710 M +1 -2 notifierdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1130862 |
Version: (using KDE 4.4.0) OS: Linux Installed from: Gentoo Packages At least in the French locale, the window of the devicenotifier plasmoid is too small to display correctly the mount/umount button. When used in a panel this makes the button invisible in the pop-up. When used on the desktop, the window is also too small, and the buttons and actions are visible, but outside the window. This simple patch makes the device notifier usable in french : kdebase-workspace-4.4.0/plasma/generic/applets/devicenotifier $ diff -BuN notifierdialog.cpp.old notifierdialog.cpp --- notifierdialog.cpp.old 2010-02-13 18:57:10.000000000 +0100 +++ notifierdialog.cpp 2010-02-13 18:20:39.000000000 +0100 @@ -504,7 +504,7 @@ updateMainLabelText(); m_widget->setLayout(l_layout); - m_widget->setMinimumSize(250, 300); + m_widget->setMinimumSize(350, 400); } void NotifierDialog::storageTeardownDone(Solid::ErrorType error, QVariant errorData, const QString & udi)