Bug 225925

Summary:	'Edit categories' dialogue should not have an 'Apply' button
Product:	[Applications] kontact	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal	CC:	montel
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Sabine Faure 2010-02-08 16:56:05 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch Kontact and go to KOrg
- Click on 'New Event' button
- Click on 'Select...' button to select a category
- Click on the 'Edit Categories...' button and an 'Edit Categories - Kontact' dialogue appears.
- Click on the 'Add' button and enter a new category name (ex: Testing)
- Click on the 'Apply' button
- The 'Edit Categories - Kontact' dialogue remains there and to close it to check the Testing check box, you have to either click on 'Ok' or 'Cancel'.

This does not make sense to have an 'Apply button' here since the dialogue needs to be closed after the category is created. I think there just should be an 'Ok' and a 'Cancel' button.

The same dialogue can be called from Settings menu/Manage Categories... but it keeps the focus until it is closed too so there is no point in having an 'Apply' button there either. 

Trunk, Svn Rev  1086926

Comment 1 Laurent Montel 2010-02-09 20:08:43 UTC

SVN commit 1087905 by mlaurent:

Fix bug #225925
CCBUG: 225925


 M  +2 -2      categoryeditdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1087905

Comment 2 Sabine Faure 2010-02-19 16:35:59 UTC

It is corrected now.

The 'Apply' button has been replaced by an 'Ok' button.

Trunk, Svn Rev 1092481