Summary: | Timezone displayed in Digital Clock plasma widget is Kentucky | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Steven Friedrich <StevenFriedrich> |
Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | riccardo, StevenFriedrich |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | FreeBSD Ports | ||
OS: | FreeBSD | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Steven Friedrich
2010-01-21 15:37:39 UTC
As an initial improvement, I would rather it return the last part of America/Kentucky/Louisville, i.e., Louisville, rather than the middle component, Kentucky. But it really should, depending on the time of year, display either EST or EDT. actually i just noted was wrong. the relevant code is in clock.cpp, a call to prettyTimezone(). I somehow assumed that this was going directly to KTimezone, but while debugging some code I noticed that it's actually a method in libplasmaclock. The culprit can be found here: http://websvn.kde.org/trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp?view=markup line 163 I already have a patch, but will ask on plasma-devel for approval, since this changes behiavour that I don't know if was intended, and if so, what are the reasons for it. SVN commit 1078901 by ruphy: Always return the most relevant part of the timezone. I will probably backport it this CET afternoon if somebody doesn't beat me at it. BUG: 223684 Signed-off-by: Riccardo Iaconelli <riccardo@kde.org> M +1 -1 clockapplet.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1078901 SVN commit 1079555 by ruphy: Always return the most relevant part of the timezone. CCBUG: 223684 Signed-off-by: Riccardo Iaconelli <riccardo@kde.org> Backporting r1078901 M +1 -1 clockapplet.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1079555 |