Summary: | KDoubleNumInput / KIntNumInput : minimum slider width are different and too big | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | DrSlony <bugs> |
Component: | kdeui | Assignee: | kdelibs bugs <kdelibs-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugs, caulier.gilles, cfeck, tschenser |
Priority: | NOR | ||
Version: | SVN | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
screenshot
screenshot screenshot screenshot screenshot screenshot digiKam 1.4.0 raw editor panel 1 digiKam 1.4.0 raw editor panel 2 digiKam 1.4.0 color balance |
Description
DrSlony
2010-01-10 00:38:19 UTC
Which tool exactly ? Please attach a screenshot... Gilles Caulier Created attachment 40174 [details]
screenshot
Created attachment 40175 [details]
screenshot
Created attachment 40176 [details]
screenshot
Created attachment 40178 [details]
screenshot
Created attachment 40179 [details]
screenshot
Created attachment 40180 [details]
screenshot
SVN commit 1081606 by jmueller: allows the stages settings items from local contrast tool to have a smaller width CCBUGS: 221989 M +4 -4 localcontrasttool.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1081606 DrSlony, Please checkout svn trunk and test if Jens commit fix your problem. Thanks in advance Gilles Caulier Commit http://websvn.kde.org/?view=rev&revision=1081612 is also relevant to this bug entry. But I think not all ui glitches are solved. As tool settings sidebar do not provide a pan area anymore (thanks Gilles, current pan area is at a better, common place now), the layout of tool settings sidebar changed at all. DrSlony, can you please evaluate tool settings sidebars with 1.1 again and provide screenshots as you do with 1.0? Thanks in advance, Jens Sorry for the long delay, I haven't received notification of bug activity by email. Looking at my old screenshots, the Local Optimize and Noise Reduction examples got fixed. The raw processing panel hadn't. Created attachment 51967 [details]
digiKam 1.4.0 raw editor panel 1
Created attachment 51968 [details]
digiKam 1.4.0 raw editor panel 2
Created attachment 51969 [details]
digiKam 1.4.0 color balance
DrSlony, Thanks for your screenshots. Sorry, but the different layout from slider setting widgets come from KDE Libs. In fact these slider come from differents API : KDoubleNumInput and KIntNumInput : http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKDoubleNumInput.html and http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKIntNumInput.html Reimplemented in libkdcraw to set a default value button (as in Aperture) : http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rnuminput.h#42 and http://lxr.kde.org/source/KDE/kdegraphics/libs/libkdcraw/libkdcraw/rnuminput.h#83 We don't fix the layout from these widget directly in libkdcraw. It's defined internally in kdelibs. I reassign this bug to KDELIBs component. Gilles Caulier The "wasted space" (too wide integer spin boxes) comes from a kdelibs bug incorrectly keeping the size when the widget was created (with maxval = INT_MAX). The next commit will fix this. Please check in digiKam if you set sane values for the range, otherwise the fix will not be visible. The difference in slider lengths comes from the difference in sizes for the spin boxes (some are integer, some are floating point). If you want all of them to be the same size, you have to "chain" them using the constructors that have a "KNumInput *below" pointer. Note that these constructors are marked deprecated, but they should work nonetheless. SVN commit 1181110 by cfeck: Fix sizeHint of KNumInput If we don't re-read the column2width after doLayout(), then we will keep the old size forever. BUG: 221989 M +8 -6 knuminput.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1181110 Christoph, what about bugfix commit rules, is it possible to have to fix on 4.5 branch too? Thanks, Jens Jens, I didn't want to backport just at day of tagging. I will backport for 4.5.3. SVN commit 1182766 by cfeck: Fix sizeHint of KNumInput (backport r1181110) CCBUG: 221989 M +3 -1 knuminput.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1182766 |