| Summary: | The font size in which the contacts are displayed is to small | ||
|---|---|---|---|
| Product: | [Applications] kaddressbook | Reporter: | Christian Trippe <christiandehne> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | anderslund, auxsvr, bugzilla, cornelis, denis.prost, fest.in, foss, kde, mail, montel, psychonaut, spielmops, sven.burmeister, tokoe |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/kdepimlibs/cc541d8a8fa056489ee56671d807aac469419594 | Version Fixed In: | 4.8.4 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot of kaddressbook
patch that remove "fontsize=-1" |
||
|
Description
Christian Trippe
2010-01-09 20:03:35 UTC
Created attachment 39717 [details]
screenshot of kaddressbook
Confirming bug still exists in KDE 4.4.1. The font size for the information pane should be configurable by the user. For some people it is important to have a lot information in one row and they accept a tiny font size to achieve this, for others the layout is less important, for them it's more important that they can *read* the information... This issue still exists in KDE-4.4.5. This issue still exists in KDE-4.6.4 kdepim 4.6 does not obey any font settings as it seems as well, i.e. changing "small font" in KDE's systemsettings does not change the font size in kaddressbook. If this is hard-coded it should at least be changed to use the "small fonts" setting. Better would be of course if the user could set which setting to use, i.e. either "normal font" or "small font". Doing fon settings per app does not make sense imho, but using KDE's different settings and not hardcoding some size is crucial. It looks from the sight, as the contact view is using the small font from the kde font settings, but it obviously should use the normal size. *** Bug 292998 has been marked as a duplicate of this bug. *** The problem is not in kaddressbook but rather in standardcontactformatter.cpp from kde pimlibs (akonadi/contact/standardcontactformatter.cpp) lines 62 and 63: 62 "<td align=\"right\" valign=\"top\" width=\"30%\"><b><font size=\"-1\" color=\"grey\">%1</font></b></td>\n" 63 "<td align=\"left\" valign=\"top\" width=\"70%\"><font size=\"-1\">%2</font></td>\n" as we can see here, the font size is set to "-1" for whatever reason. I patched it locally, and now I have nice big fonts. As this is a rather generic component, I have no idea whether it's a bad idea to change it there. It might break things in other places. So dear developers, please 1) change this to respect user settings or at least global KDE settings if it doesn't break things or 2) use something else in kaddressbook to have the fonts at an acceptable size there. Thank you very much :) Created attachment 71119 [details] patch that remove "fontsize=-1" FYI: This patch is added to kdepimlibs4 in openSUSE. It will be part of the coming 12.2 release. Based on comment 9. Git commit 9360eadef4001130891e747e3c07689d241560ed by Allen Winter. Committed on 20/05/2012 at 22:23. Pushed by winterz into branch 'master'. remove "size = -1" from font size html element. should help the tiny font size complaints. FIXED-IN: 4.8.4 MERGE: 4.8 M +2 -2 akonadi/contact/standardcontactformatter.cpp M +5 -5 akonadi/contact/standardcontactgroupformatter.cpp http://commits.kde.org/kdepimlibs/9360eadef4001130891e747e3c07689d241560ed Git commit cc541d8a8fa056489ee56671d807aac469419594 by Allen Winter. Committed on 20/05/2012 at 22:23. Pushed by winterz into branch 'KDE/4.8'. remove "size = -1" from font size html element. should help the tiny font size complaints. FIXED-IN: 4.8.4 MERGE: 4.8 (cherry picked from commit 9360eadef4001130891e747e3c07689d241560ed) M +2 -2 akonadi/contact/standardcontactformatter.cpp M +5 -5 akonadi/contact/standardcontactgroupformatter.cpp http://commits.kde.org/kdepimlibs/cc541d8a8fa056489ee56671d807aac469419594 *** Bug 285009 has been marked as a duplicate of this bug. *** And this bug is back with 4.9 Beta / RC, since it got moved to kaddressbook/viewertemplates/contact_row.html kaddressbook/viewertemplates/contactgroup_memberrow.html kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html Please fix this before 4.9 final is out, the font is definitely not readable for most settings with a font size of -1, which you are setting there. Thanks, kind regards Christian It's false it works fine and viewertemplates is used just when we use grandlee and we can't use grandlee in kaddressbook... Ok will remove font size -1 in theses files if a day we uses grandlee but this bug is closes and fixed before this patch. Git commit 9bb05459b02e6175365cbc1d7357da6b2f2f27e3 by Montel Laurent. Committed on 29/06/2012 at 09:15. Pushed by mlaurent into branch 'master'. Remove font size=-1 when we use grandlee but we don't use grandlee Perhaps in the future we will use it. M +2 -2 kaddressbook/viewertemplates/contact_row.html M +2 -2 kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html M +2 -2 kaddressbook/viewertemplates/contactgroup_memberrow.html http://commits.kde.org/kdepim/9bb05459b02e6175365cbc1d7357da6b2f2f27e3 Git commit ec5add174490dd9738d0d99e7efa02397de0e6e5 by Montel Laurent. Committed on 29/06/2012 at 09:15. Pushed by mlaurent into branch 'KDE/4.9'. Remove font size=-1 when we use grandlee but we don't use grandlee Perhaps in the future we will use it. (cherry picked from commit 9bb05459b02e6175365cbc1d7357da6b2f2f27e3) M +2 -2 kaddressbook/viewertemplates/contact_row.html M +2 -2 kaddressbook/viewertemplates/contactgroup_additionalfieldrow.html M +2 -2 kaddressbook/viewertemplates/contactgroup_memberrow.html http://commits.kde.org/kdepim/ec5add174490dd9738d0d99e7efa02397de0e6e5 Thanks for the information, then I have to check with gentoo "packagers". Because when I build current 4.9 RC 1 without changes, the fonts are too small. When I change the mentioned files (I assume one of them would be sufficient, but I'll have to check which one) and rebuild, the fonts are fine. This is a bit strange, since gentoo usually just builds the tarballs as provided, but it should be rather easy to find out what's going wrong here, then. Thanks for the fix, kind regards |