Bug 221140

I know that LR use MDI with Light Table.

I'm not sure if it's the right way here.

At least we can provide a view with 2 preview or 4 preview. It's enough ?

Gilles Caulier

Everything possible to be made, is welcomed of course!
Maybe three options to be able to choose from, if that`s the "easy" way to implement it..
Compare 2, 4 or 6 images!

(In reply to comment #2)
> Everything possible to be made, is welcomed of course!
> Maybe three options to be able to choose from, if that`s the "easy" way to
> implement it..
> Compare 2, 4 or 6 images!

Bridge could be a great inspiration here.
Rinus

Linus,

This is my mockup implemented with current 2.0.0, not fully suitable of course, but it's possible to do it as you can see :

6 panel : http://www.flickr.com/photos/digikam/5713503110/sizes/o/in/photostream/
4 panel : http://www.flickr.com/photos/digikam/5713502958/sizes/o/in/photostream/

What's the difference with current LT using 2 panel :

- The left sidebar is removed. Only Right sidebar still here, as under Image Editor. To see all information for one item, just left click on one panel. It will be selected (a colored frame is used around canvas to indicate selection)
I removed left sidebar because it take a lot of space when Left and right sidebar are expanded.

- The status-bar only include one slider to change zoom level. You must select an item to zoom inside. If all view are synchronized, all panel zoom at the same time.

- The status bar show only one file name : the current item selected.

This behavior sound like acceptable for you ?

Can you post some Adobe Bride Light Table screen-shots to take some inspiration here, if something is missing in my mockup ?

Thanks in advance

Gilles Caulier

*** This bug has been confirmed by popular vote. ***

a few first thoughts:

1)
first of all, it looks great.

2)
Personaly I would very rarely (almost never) use a mode with more than 4 
pictures. But if it is possible:

- what happens if you are in 4 view and select number 5. Is the window 
automaticly rearranged or do you need to preselect a view mode?

- And what happens if you are in 6 view and you select a seventh?

3)
In your screenshot everything except ¨Synchronize¨ and ¨Full  screen¨ 
looks greyed out. But ¨Slideshow¨ would be very usefull here too.

4) It would be great if the pictures in the view could be selected 
automaticly if you richtclick within the picture or elseway as the 
action you are going to perform is appllied to to picture the mouse 
pointer is in instead of to the selected picture. Else you have to left 
click to select and subsequently richtclick to perform an action such as 
tag as ¨select¨ or ¨reject¨.

Or alternatively, what do you think of this: go with Tab or Arrow trough 
the picture and use del to either actually delete or add a ¨reject¨ 
tag/flag. Or use the enter key to attach a ¨select¨ tag/flag

5) It is a bit beside this but I think it would be an improvement if 
there is always an option to put images as a new selection on the 
lighttable instead of only ¨add to lightable¨

Thanks for the great work sofar!

Rinus


Op 12-05-11 17:59, Gilles Caulier schreef:
> https://bugs.kde.org/show_bug.cgi?id=221140
>
>
> Gilles Caulier<caulier.gilles@gmail.com>  changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |caulier.gilles@gmail.com
>
>
>
>
> --- Comment #4 from Gilles Caulier<caulier gilles gmail com>   2011-05-12 17:59:06 ---
> Linus,
>
> This is my mockup implemented with current 2.0.0, not fully suitable of course,
> but it's possible to do it as you can see :
>
> 6 panel :
> http://www.flickr.com/photos/digikam/5713503110/sizes/o/in/photostream/
> 4 panel :
> http://www.flickr.com/photos/digikam/5713502958/sizes/o/in/photostream/
>
> What's the difference with current LT using 2 panel :
>
> - The left sidebar is removed. Only Right sidebar still here, as under Image
> Editor. To see all information for one item, just left click on one panel. It
> will be selected (a colored frame is used around canvas to indicate selection)
> I removed left sidebar because it take a lot of space when Left and right
> sidebar are expanded.
 From my point of view no need for left sidebar
> - The status-bar only include one slider to change zoom level. You must select
> an item to zoom inside. If all view are synchronized, all panel zoom at the
> same time.
That´s great, for this function there is no need for individual zooming 
or panning and synchronized zooming is way better than the magnifier 
tool in Bridge
> - The status bar show only one file name : the current item selected.
I am in doubt about this one. If it´s not too hard to implement I would 
prefer to see the name in each picture, though not necessery.
> This behavior sound like acceptable for you ?
>
> Can you post some Adobe Bride Light Table screen-shots to take some inspiration
> here, if something is missing in my mockup ?
I will try this later, I don´t think it will have to add much to this ideas.
> Thanks in advance
>
> Gilles Caulier
>

That looks and sounds (by the description) very beautiful :)
Thank you for working on it!

I will also remind another "wish" I made a year ago, regarding the exif information. Check bug 221142.
Any thoughts of implementing something like this for the LightTable fullscreen mode?

Rinus,

>- what happens if you are in 4 view and select number 5. Is the window 
>automaticly rearranged or do you need to preselect a view mode?

??? 4 view is 4 view. no more. how do can selected a 5th view if this one is not displayed on screen ???

>- And what happens if you are in 6 view and you select a seventh?

Same than 4 view.

Note that selection is unique and done over canvas item (zommable). On the top, the thumbbar items are selectable, but only to be removed from thumbbar...

If you select an item from thumbbar, canvas item is selected too, and vis versa. If and item is selected from thumbbar and is not present somewhere in canvas, nothing happen...

Gilles Caulier

Yes you are right. It is my misunderstanding of dk´s lighttable. I 
confused it with Bridge´s compare function.

Imagine a row of 100 thumbs. The point is to select a thumb and control 
or shift click to select more thumbs and than to see the selected thumbs 
in the compare layout.

Do you understand what I mean. else I can produce a video to show.
Rinus

Op 12-05-11 19:25, Gilles Caulier schreef:
> https://bugs.kde.org/show_bug.cgi?id=221140
>
>
>
>
>
> --- Comment #8 from Gilles Caulier<caulier gilles gmail com>   2011-05-12 19:25:42 ---
> Rinus,
>
>> - what happens if you are in 4 view and select number 5. Is the window
>> automaticly rearranged or do you need to preselect a view mode?
> ??? 4 view is 4 view. no more. how do can selected a 5th view if this one is
> not displayed on screen ???
>
>> - And what happens if you are in 6 view and you select a seventh?
> Same than 4 view.
>
> Note that selection is unique and done over canvas item (zommable). On the top,
> the thumbbar items are selectable, but only to be removed from thumbbar...
>
> If you select an item from thumbbar, canvas item is selected too, and vis
> versa. If and item is selected from thumbbar and is not present somewhere in
> canvas, nothing happen...
>
> Gilles Caulier
>

Rinus, 

Yes, i know this Bridge work-flow. digiKam is a little bit different : You set items on LT (on thumb-bar is fact) and with Drag & Drop, you place items to compare on right panel...

Gilles Caulier

That is a nice feature, but does not suit my needs. (It was hard to say 
it) I wonder what other voters expected.

Rinus

Op 12-05-11 19:58, Gilles Caulier schreef:
> https://bugs.kde.org/show_bug.cgi?id=221140
>
>
>
>
>
> --- Comment #10 from Gilles Caulier<caulier gilles gmail com>   2011-05-12 19:58:42 ---
> Rinus,
>
> Yes, i know this Bridge work-flow. digiKam is a little bit different : You set
> items on LT (on thumb-bar is fact) and with Drag&  Drop, you place items to
> compare on right panel...
>
> Gilles Caulier
>

Hello,

thank you all for giving this wish such a big momentum in this short time.

If comparing 6 pictures I think it would be better to place them in 2 rows and 3 columns, not the other way round, because most of modern monitors are wide screens.

I think there is a way to implement what I understand Rinus wants to see. It would go like this.
You put all the images you possibly want to compare into light tables thumb bar. Then you drag the first 4 or 6 pictures onto the light table. There, you do the comparison, choose the best by clicking on it, and the press <CoolShortCut>. By pressing this short cut the 3 or 5 not selected pictures are removed (from light table only, from light table and the thumb bar, or even from the hard disk) and the now empty places are filled up with the next 3 or 5 images from the thumb bar.
Is this workflow clear?

Cheers, Wolfgang

Op 12-05-11 22:13, Wolfgang Mader schreef:
> https://bugs.kde.org/show_bug.cgi?id=221140
>
>
> Wolfgang Mader<Wolfgang_Mader@brain-frog.de>  changed:
>
>             What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                   CC|                            |Wolfgang_Mader@brain-frog.d
>                     |                            |e
>
>
>
>
> --- Comment #12 from Wolfgang Mader<Wolfgang_Mader brain-frog de>   2011-05-12 22:13:47 ---
> Hello,
>
> thank you all for giving this wish such a big momentum in this short time.
>
> If comparing 6 pictures I think it would be better to place them in 2 rows and
> 3 columns, not the other way round, because most of modern monitors are wide
> screens.
>
I agree with this
> I think there is a way to implement what I understand Rinus wants to see. It
> would go like this.
> You put all the images you possibly want to compare into light tables thumb
> bar. Then you drag the first 4 or 6 pictures onto the light table. There, you
> do the comparison, choose the best by clicking on it, and the press
> <CoolShortCut>. By pressing this short cut the 3 or 5 not selected pictures are
> removed (from light table only, from light table and the thumb bar, or even
> from the hard disk) and the now empty places are filled up with the next 3 or 5
> images from the thumb bar.
> Is this workflow clear?
This would not solve all the problems, because the images you want to 
see in compare view are not necessarely  the next 4/6 or even not 
necessarely  contiguous and besides that the formerly choosen picture(s) 
should not always be part of the next selecttion to compare.

The main point, is as I see it. that you (or your wrist) would go crazy 
and it would be far to time consuming if you have to drag all those 
pictures one by one to the LT. (That´s the downside of the 7 frames per 
second era)
Rinus
> Cheers, Wolfgang
>

After a little sleep to wash yesterdays euphorias and disappointments away, I had a dream.
Why not leave the LT alone and implement it in album view. Here can multiple thumbs being selected. The question is: is it possible to implement that multiple selection leads to multiple view?

Rinus

Created attachment 59960 [details]
compare function in album view possible?

The current implementation from git master use the same thumbbar from album view, where multiple selection is possible...

Gilles Caulier

(In reply to comment #16)
> The current implementation from git master use the same thumbbar from album
> view, where multiple selection is possible...
> 
> Gilles Caulier

Anyway, it would be always right there without the extra stap to put it on the LT.
Maybe multiple selection can automaticly call a different routine instead of changing the existing code.
Rinus

Op 13-05-11 10:26, Gilles Caulier schreef:
> https://bugs.kde.org/show_bug.cgi?id=221140
>
>
>
>
>
> --- Comment #16 from Gilles Caulier<caulier gilles gmail com>   2011-05-13 10:26:09 ---
> The current implementation from git master use the same thumbbar from album
> view, where multiple selection is possible...
>
> Gilles Caulier
>

Anyway, it would be always right there without the extra stap to put it on the
LT.
Maybe multiple selection can automaticly call a different routine instead of
changing the existing code.
Rinus

this depends on the size of the moniter and the resolution!!!

I say 4 would be fine for most users!

The way Aurelien Gateau did it in Gwenview is awesome. Would love to see some very similar in digikam.
Rinus

*** Bug 173061 has been marked as a duplicate of this bug. ***

Thank you for the bug report.

As this report hasn't seen any changes in 5 years or more, we ask if you can please confirm that the issue still persists.

If this bug is no longer persisting or relevant please change the status to resolved.

The issue (feature request) is still relevant. I have recently posted similar report here: bug #440787.