| Summary: | kmail improperly makes path name italic | ||
|---|---|---|---|
| Product: | [Applications] kdepimlibs | Reporter: | Andrey Borzenkov <arvidjaar> |
| Component: | kpimutils | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kollix |
| Priority: | NOR | ||
| Version: | 4.4 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
Example of manged path name
bugfix |
||
Created attachment 38469 [details]
Example of manged path name
I can not reproduce this with KDE 4.3.3 Which version of kmail are you using ? 1.12.90 KDE 4.3.75 (KDE 4.3.75 (KDE 4.4 >= 20091113)) Would you be so kind to reopen it because it was closed incorrectly? And yes, as you have seen, it is a regression in 4.4. Created attachment 38523 [details]
bugfix
This patch forbids text highlighting unless highlighting markups are followed by whitespaces (previous behavior restored).
This test breaks 3 unit tests, for example the case "*BLA BLA BLA BLA*.".
Please have a look at those and modify the patch so that they still pass.
The new unit test for this case would be:
QTest::newRow( "" ) << "the /etc/{rsyslog.d,syslog-ng.d}/package.rpmnew file" << 0x09 << "the /etc/{rsyslog.d,syslog-ng.d}/package.rpmnew file";
I know it breaks these tests, I said it before: the old behaviour is restored, so highlighting marks can *not* be followed by punctuation marks. Oh sorry, I didn't read closely enough, then. Could you also update the test, then, either by uncommenting the failing tests or by marking them with QEXCEPT_FAIL? Committed with r1062666, thanks. |
Version: (using Devel) OS: Linux Installed from: Compiled sources See screenshot. In the /etc/{rsyslog.d,syslog-ng.d}/package.rpmnew the first two slashes are gone and etc is shown in italic. This is rather confusing.