| Summary: | Desktop cube reflection incorrect after doing a 90° down rotation - (Desktop cube animation 0.1.0) | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Christophe S <schristophe> |
| Component: | effects-various | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | djrlual1 |
| Priority: | VLO | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/6408e0ba6045d03b8872eab71060ac8d6f13ee9f | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | visual steps to reproduce the bug | ||
|
Description
Christophe S
2009-11-07 21:32:05 UTC
Created attachment 38163 [details]
visual steps to reproduce the bug
here is the way to reproduce the bug from left to right
Kind regards
Comment on attachment 38163 [details]
visual steps to reproduce the bug
2 last screens show a wrong reflection f the cube
actually I know about this bug for quite some time, but I wanted to have a proper fix instead of just limit the rotation to 89.9 °. But haven't had the time for it and to be honest it's just a small visual glitch ;-) Hi, Note that I'm very glad of using KDE .. I'm not throwing any stones at you ;) I just report something I have noticed .. and Perhaps am I the only one to play all day with the cube ;) ?(in fact I came to that glitch by mistake ;) ) I know that it is just a very minor visual glitch ;) - but as I always said people takes more attention to what they see than anything else ... And small glitches are perhaps very difficult to find - cause you need silly users using the product for a long time to notice it ... that's why I report it :).. In fact I have a small lists of bug like this (not related to the cube :)]- it should probably be in a "paper cut" bug list - is it such a list for kde ?... shouldn't I notice it ? Kind regards (In reply to comment #4) > Hi, > > Note that I'm very glad of using KDE .. I'm not throwing any stones at you ;) I > just report something I have noticed .. I didn't think that you are throwing stone ;-) We receive bug reports every day, it's quite normal and we are thankfull for users reporting bugs. > I know that it is just a very minor visual glitch ;) - but as I always said > people takes more attention to what they see than anything else ... That's possible, but fixing "real" bugs in the limited time we have is more important. That's why I set the priority to very low > it should probably be in a "paper cut" bug list - is it such a list for kde ? No there is no such list. That's an Ubuntu project. My desktop pc animation of the cube does not work that I do nothing? Git commit 6408e0ba6045d03b8872eab71060ac8d6f13ee9f by Igor Poboiko. Committed on 01/06/2018 at 15:32. Pushed by poboiko into branch 'master'. [effects/cube] Fix animation and reflection issues The main problem was that inside the effect there was manualVerticalAngle, which did not represent the actual rotation angle of the cube during the animation, but used to calculate the position of the reflection. The actual angle was calculated on-the-fly and was not exposed outside. Brief description of what the code does: - variables currentAngle and verticalCurrentAngle now always represent the current position of the cube. They are updated when one uses the mouse and inside the rotateCube() method, which is called in prePaintScreen(). - two queues, animations (used for Start / Stop / Left / Right) and verticalAnimations (used for Up / Down) are used for scheduling the animations if i.e. user presses several keys in a row. The code checks whether the last animation has finished (and thus we need to start a new one) inside prePaintScreen() and postPaintScreen() - when the animation starts, code saves the starting position of the cube inside startAngle, startFrontDesktop and verticalStartAngle variables, which are used to calculate the actual cube position during the animation later. This is done by startAnimation() and startVerticalAnimation(), which also calculates the QTimeLine curves needed for animation Related: bug 373101 Differential Revision: https://phabricator.kde.org/D9860 M +256 -441 effects/cube/cube.cpp M +26 -19 effects/cube/cube.h https://commits.kde.org/kwin/6408e0ba6045d03b8872eab71060ac8d6f13ee9f |