Bug 212106

Summary:	Unable to export original file to Flickr [patch]
Product:	[Applications] digikam	Reporter:	Stanislav Ochotnicky <sochotnicky>
Component:	Plugin-WebService-Flickr	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	caulier.gilles, esby, lure, p.edelman
Priority:	NOR
Version:	5.6.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.2.0
Sentry Crash Report:
Attachments:	Patch adding requested feature Support for exporting original file to flickr

Description Stanislav Ochotnicky 2009-10-27 21:17:51 UTC

Version:            (using Devel)
OS:                Linux
Installed from:    Compiled sources

Flickr export plugin currently doesn't enable exporting of original non-resized/non-recompressed image. 

Even when resizing of image is disabled, the image is still recompressed and thus quality suffers.

Provide a way to upload original photos to flickr.

Comment 1 Stanislav Ochotnicky 2009-10-27 21:19:14 UTC

Created attachment 37919 [details]
Patch adding requested feature

This is by no means perfect I am sure. 

I can see a problem with filetypes that flickr doesn't support (e.g. trying to upload original RAW photo).

Comment 2 Luka Renko 2009-11-13 12:46:29 UTC

There is no reason to resize if user did not select to resize at all.
For RAW, we will extract preview image anyhow.

I will try to factorize this code (as we have the same/similar in other plugins)

Comment 3 Stanislav Ochotnicky 2009-11-13 13:16:14 UTC

Just to clarify: If user doesn't select "resize" then no resizing is done by flickr plugin. What it does is recompress that same image (preserving dimensions, etc) thus adding jpeg artifacts (and possibly making the image bigger). So I guess what you wanted to write was:
"There is no reason to recompress if user did not select to resize at all."

Comment 4 Luka Renko 2009-11-13 13:21:07 UTC

yes! thanks for correcting me.

Comment 5 Stanislav Ochotnicky 2010-08-28 22:19:21 UTC

Just checking...is there any progress on this? I have recently updated kipi-plugins and my patch still works even for 1.4.0 and trunk versions. I am attaching a bit improved patch (whitespace cleanup & resize/recompress options are hidden when "send original" checkbox is selected). 

Can someone with permissions change this bug to version from 0.8.0 to 1.4.0 please?

Comment 6 Stanislav Ochotnicky 2010-08-28 22:21:18 UTC

Created attachment 51068 [details]
Support for exporting original file to flickr

Comment 7 caulier.gilles 2010-09-01 09:55:45 UTC

Thanks for your patch. We  will try to review your patch for next stable release 1.5.0

Gilles Caulier

Comment 8 Petri Damstén 2011-09-13 07:31:42 UTC

Git commit 3a7c87884d84d8e531f36c1e287805b96c0e87eb by Petri Damstén.
Committed on 12/09/2011 at 11:00.
Pushed by pdamsten into branch 'master'.

Unable to export original file to Flickr
BUG: 212106

M  +12   -6    flickrexport/flickrtalker.cpp
M  +1    -1    flickrexport/flickrtalker.h
M  +26   -8    flickrexport/flickrwidget.cpp
M  +5    -0    flickrexport/flickrwidget.h
M  +4    -0    flickrexport/flickrwindow.cpp
M  +1    -0    flickrexport/flickrwindow.h

http://commits.kde.org/kipi-plugins/3a7c87884d84d8e531f36c1e287805b96c0e87eb

Comment 9 Stanislav Ochotnicky 2011-09-13 08:54:35 UTC

Thank you. It's great that I won't have to patch kipi-plugins anymore :-)

Comment 10 caulier.gilles 2011-12-21 18:11:45 UTC

*** Bug 241587 has been marked as a duplicate of this bug. ***