Bug 210956

Summary:	Zoom slider looks not centered with Oxygen style [patch]
Product:	[Applications] digikam	Reporter:	Ignat Semenov <i.semenov.kde>
Component:	Usability-Ergonomy	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	1.0.0
Attachments:	proposed patch patch #2

Description Ignat Semenov 2009-10-18 11:54:38 UTC

Version:            (using Devel)
Compiler:          gcc 4.4.1 
OS:                Linux
Installed from:    Compiled sources

When using Oygen widget style, the zoom slider looks off-center a few pixels. It does, however, look fine when using other styles. I've taken a look into the code and found the guilty line. In Dolphin, the code for setting up the zoom slider and buttons is identical, but doesn't include this line. I've got no clue why it's there, but removing it really helps.

Comment 1 Ignat Semenov 2009-10-18 11:56:50 UTC

Created attachment 37645 [details]
proposed patch

Comment 2 Andi Clemens 2009-10-18 12:19:48 UTC

Right, this doesn't make sense. I'll apply your patch! Thanks...

Comment 3 Andi Clemens 2009-10-18 12:21:18 UTC

SVN commit 1037037 by aclemens:

Let the slider decide what size to take. I'll leave this code commented if
someone really thinks we need this.

BUG:210956

 M  +1 -1      statuszoombar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037037

Comment 4 Ignat Semenov 2009-10-18 16:19:56 UTC

Created attachment 37647 [details]
patch #2

It appears that setInvertedControls() in zoomSlider is unnecessary (using Qt4.6 snapshot). If it's not set, then Ctrl+Mouse Wheel Up zooms in the view and Mouse Wheel Up over zoom slider does the same. Zoom out works fine as well.