| Summary: | Please allow locking image zoom on the light table [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | kgw |
| Component: | LightTable-Canvas | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | caulier.gilles, Julien, languitar, marcel.wiesweg |
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | 1.1.0 | |
| Sentry Crash Report: | |||
| Attachments: |
Patch to keep a set zoom ratio when changing images...
Patch to keep a set zoom ratio when changing images. New version of the patch against rev 1054503 |
||
|
Description
kgw
2009-10-17 20:53:09 UTC
Created attachment 37802 [details]
Patch to keep a set zoom ratio when changing images...
Please would anyone with the knowledge how to do this properly in the context of digikam make this an option (setting either true for the previous behavior and false for the behavior I crave for)...
Created attachment 37821 [details]
Patch to keep a set zoom ratio when changing images.
I have added a setting into the light table settings group.
Should we reset the zoom at all when loading a new image? I mean, do we want an option for this or do we want to change it without offering an option? If we want an option, what should be the default value? My viewpoint : an option with the current behavior as default settings. We need more viewpoints here... Please Gilles I'm the one who would like this new behavior but the old one has been around for long enough as to have enough merit as not to abandon it. So even I second Gilles viewpoint - see my attached patch... I think the current situation make the light table quite impossible to use. When comparing picture they should always be at the same zoom ratio. I don't really understand the current behavior, even when you click on synchronize the zoom ratio is often reset to "zoom to fit". I think the zoom ratio should never be changed without user explicitly asking for it. Julien Created attachment 38595 [details]
New version of the patch against rev 1054503
Hi, I tested the patch with current version it works well. I my opinion it should not be an option, or at least the new behavior should be the default. Julien Ok, let's go to take a try to this patch. apply it to svn, it's very simple to test... Gilles Julien, Can you adjust this patch to not include settings panel change and use new defaut behaviors as well. I would to see it included in 1.1.0 release Thanks in advance Gilles Caulier Gilles, The patch is already applied, i will remove the option. Julien SVN commit 1078909 by jnarboux: Undo compit 1054504, this removes the option for updating zoom ratio when new image is loaded in lighttable. Make new behaviour be old default, we never update zoom ratio. CCBUGS: 210910 M +1 -7 lighttable/lighttablepreview.cpp M +0 -1 lighttable/lighttablewindow_p.h M +0 -9 setup/setuplighttable.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1078909 |