Summary: | [PATCH] add Show Menubar to Settings menu to allow hiding menubar | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Mike Smiley <mhsmiley> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | codenamed004, georgi, info, valentyn.pavliuchenko, ziom_d |
Priority: | NOR | ||
Version First Reported In: | 2.3-GIT | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.4.1 | |
Sentry Crash Report: | |||
Attachments: |
Adds ability to show/hide menu bar
Adds ability to show/hide menu bar |
Description
Mike Smiley
2009-10-09 21:59:25 UTC
Yeah, it's needed, especially for audio player. It is part of flexible UI, that Amarok is going to have last time (and must have - to feel comfortable). *** Bug 218260 has been marked as a duplicate of this bug. *** *** Bug 219167 has been marked as a duplicate of this bug. *** Often it is objected to the "hide menu"-option, that users occasionally may type the shortcut and make the bar disappear without knowing how the get it back - it happened to me a few years ago, too. A solution would be to add the toggle option, but to NOT define a shortcut for it. Just write that in the release announcement, so that the ones who care can add crtl + m (or whatever) - which is no big effort -, and the ones who don't care don't have to do anything at all. The way it works in most applications, I think, is that the first time you use the shrotcut or the menu item, you get a popup message explaining that the menu will now be hidden, and that you can press the shortcut to get it back. The popup has a checkbox to not show it again, once you're used to the shortcut. Your solutions has the problem that if I hide the menu without having set up a shortcut before that, I can't get it back at all. Yes, it would be a problem, if there were a checkbox in the options or in the menu, I was just thinking about a shortcut as the only way for toggling the bar on/off, but maybe that's not a good idea. The pop-up surely is superior. *** Bug 232080 has been marked as a duplicate of this bug. *** This would be a nice feature. As Georgi Chulkov said, many other KDE apps display the first time a message that explain all this (ctrl+m ...). Alternatively, what do you think about removing the menubar, like many apps now do? e.g. Bangarang, Mini(tunes|tube), rekonq (and other web browsers) The status bar is in my point of view almost useless, should also be made possible to hide or remove. Created attachment 51833 [details]
Adds ability to show/hide menu bar
Implemented in the same way as in Dolphin. "Show menubar" menu item (with Ctrl+M shortcut) is added to both main menu and popup menu of the main window.
Created attachment 51835 [details]
Adds ability to show/hide menu bar
Implemented in the same way as in Dolphin. "Show menubar" menu item (with
Ctrl+M shortcut) is added to both main menu and popup menu of the main window.
Updated version, fixed initial checked status of the menu item.
*** This bug has been confirmed by popular vote. *** Anybody there? Valentin, now that reviewboard is working for Amarok, please submit your patch there: http://git.reviewboard.kde.org Please close this wish as done. Closing. |