| Summary: | ktimetracker lost nearly all actions with commit 1026315 in branch | ||
|---|---|---|---|
| Product: | [Applications] ktimetracker | Reporter: | Burkhard Lück <lueck> |
| Component: | general | Assignee: | Thorsten Staerk <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, bogdan_gr |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Burkhard Lück
2009-10-05 22:03:44 UTC
thank you, very valuable report! Cannot reproduce, please give an example of a lost action. svn info kdepim/ktimetracker URL: https://lueck@svn.kde.org/home/kde/branches/KDE/4.3/kdepim/ktimetracker Basis des Projektarchivs: https://lueck@svn.kde.org/home/kde UUID des Projektarchivs: 283d02a7-25f6-0310-bc7c-ecb5cbfe19da Revision: 1031719 Menu: File -> Import -> "" File -> Export -> "" Clock -> "" Task -> "" Settings + Help menu ok Main Toolbar + Tasks selected, but no toolbar With this patch I get all actions back:
$ svn diff kdepim/ktimetracker/
Index: kdepim/ktimetracker/mainwindow.cpp
==============================================
--- kdepim/ktimetracker/mainwindow.cpp (Revision 1032238)
+++ kdepim/ktimetracker/mainwindow.cpp (Arbeitskopie)
@@ -73,6 +73,7 @@
((TimetrackerWidget) (m_part->widget())).openFile(icsfile);
connect(configureAction, SIGNAL(triggered(bool)),
m_part->widget(), SLOT(showSettingsDialog()));
+ ((TimetrackerWidget *) (m_part->widget()))->setupActions( actionCollection() );
m_part->openFile(icsfile);
setupGUI();
}
Fails for me too I just updated my Kubuntu 9.04 with the KDE 4.3.2 packages from deb http://ppa.launchpad.net/kubuntu-ppa/backports/ubuntu jaunty main deb http://ppa.launchpad.net/kubuntu-ppa/staging/ubuntu jaunty main $ ktimetracker --version Qt: 4.5.2 KDE: 4.3.2 (KDE 4.3.2) KDE-Zeitplaner: 4.3.1 This version of ktimetracker is broken as described in my comment #3, therefore unusable. *** Bug 210441 has been marked as a duplicate of this bug. *** I accept this bug as reproducible because others can reproduce it, see bug 210441. SVN commit 1035393 by tstaerk: Code cleanup CCBUGS:209570 M +1 -1 mainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1035393 (In reply to comment #4) Burkhard, > + ((TimetrackerWidget *) (m_part->widget()))->setupActions( > actionCollection() ); In my checkout, this line is already in. As well for trunk as for 4.3. Can you explain? all, as I tell from http://websvn.kde.org/?view=revision&revision=1032238 you are working in a branch that I do not know. (In reply to comment #10) Then your 4.3 checkout is old, see how that line is not there in http://websvn.kde.org/branches/KDE/4.3/kdepim/ktimetracker/mainwindow.cpp?view=markup Indeed it was old and I wonder how I could overlook this. The relevant commit is http://websvn.kde.org/branches/KDE/4.3/kdepim/ktimetracker/mainwindow.cpp?r1=1026315&r2=1026314&pathrev=1026315 This commit was done to resolve bug 194865. Thanks you two for the correction. SVN commit 1035759 by tstaerk: Show menues again in ktimetracker. BUGS:209570 M +1 -0 mainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1035759 |