| Summary: | i18n bug trunk + branch: catalog not loaded, wrong use of I18N_NOOP | ||
|---|---|---|---|
| Product: | [Applications] kget | Reporter: | Burkhard Lück <lueck> |
| Component: | plasma widget | Assignee: | KGet authors <kget> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | fix to use proper catalog + i18n call | ||
Created attachment 37148 [details]
fix to use proper catalog + i18n call
Thanks for notifying... please commit! :) Lukas SVN commit 1027741 by lueck: load translation catalog, fix wrong use of I18N_NOOP in trunk CCBUG:208373 M +1 -0 applet/barapplet/kgetbarapplet.cpp M +2 -0 applet/panelbar/kgetpanelbar.cpp M +1 -0 applet/piechart/kgetpiechart.cpp M +4 -5 engine/kgetengine.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1027741 SVN commit 1027742 by lueck: backport from trunk r1027741: load translation catalog, fix wrong use of I18N_NOOP BUG:208373 M +1 -0 applet/barapplet/kgetbarapplet.cpp M +2 -0 applet/panelbar/kgetpanelbar.cpp M +1 -0 applet/piechart/kgetpiechart.cpp M +5 -7 engine/kgetengine.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1027742 |
Version: (using Devel) Installed from: Compiled sources the kget plasmoids and datengine are buggy i18n wise, since 2 years. That's incredible. kgetengine.cpp has these lines: setData(I18N_NOOP(name), I18N_NOOP("error"), false); setData(I18N_NOOP(name), I18N_NOOP("transfers"), kget_interface.transfers().value()); setData(I18N_NOOP(name), I18N_NOOP("error"), true); setData(I18N_NOOP(name), I18N_NOOP("errorMessage"), I18N_NOOP("Is KGet up and running?")); setData(I18N_NOOP("KGet"), I18N_NOOP("error"), false); setData(I18N_NOOP("KGet"), I18N_NOOP("transfers"), transfers); api says setData (source, key, value) The I18N_NOOP do nothing but mark the messages only for extraction, this does not return a translation. And to be honest, do you realy want a translated source and key in these calls? I'm sure that will not work. the only place where you need an i18n here is the string "Is KGet up and running?", which I see untranslated in the GUI cause of the wrong I18N_NOOP, which has to be changed to i18n(). the patch solves this issue, any objection to commit?