Bug 206357

Summary:	Tools / Resize - two dimensions are not proportionately resized
Product:	[Applications] digikam	Reporter:	Milan Knížek <knizek>
Component:	Plugin-Bqm-Resize	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	agateau, caulier.gilles, languitar
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	0.7.0
Sentry Crash Report:
Attachments:	Patch for 2 dim proportional resize Patch for 2 dim proportional resize

Description Milan Knížek 2009-09-05 12:54:35 UTC

Version:           digikam-1.0.0. beta4 kipi-plugins-0.6.0 (using KDE 4.2.4)
OS:                Linux
Installed from:    Compiled From Sources

In digiKam 1.0.0 beta4 with kipi-plugins 0.6.0 the image resizing (in Tools / Resize) with type "Proportional (2 dim)" does not keep the x:y ratio - images are distorted to fit the destination size in pixels.

Comment 1 Aurelien Gateau 2009-09-06 15:03:39 UTC

I can reproduce. Thanks for reporting this.

Comment 2 Johannes Wienke 2009-09-23 16:34:20 UTC

I could patch this, but what exactly is the desired behaviour for the border setting?

Comment 3 Johannes Wienke 2009-09-23 18:39:04 UTC

With a first guess how border should be interpreted... Here is a patch.

Comment 4 Johannes Wienke 2009-09-23 18:42:30 UTC

Created attachment 37130 [details]
Patch for 2 dim proportional resize

Comment 5 Andi Clemens 2009-09-23 18:47:01 UTC

I would use qMin and qMax for portability...

Comment 6 Johannes Wienke 2009-09-23 18:59:01 UTC

Created attachment 37131 [details]
Patch for 2 dim proportional resize

Now with qMin and qMax

Comment 7 caulier.gilles 2009-09-24 12:26:39 UTC

SVN commit 1027561 by cgilles:

fix proportionnal resizing rule.with 2 dims
BUGS: 206357
BUGS: 135411


 M  +108 -59   resizeimagesdialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1027561