Bug 205880

Summary:	Bugs in Aggregation GroupByDateRange
Product:	[Unmaintained] kmail	Reporter:	A. Pfaller <apfaller>
Component:	general	Assignee:	kdepim bugs <pim-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Fix for the previously described problems

Description A. Pfaller 2009-09-01 11:16:06 UTC

Version:            (using KDE 4.3.0)
OS:                Linux
Installed from:    Compiled From Sources

1) Using aggregation by date range in the messagelist showed a couple of messages from the beginning of August 2009 under an "Unknown" heading when displayed at the end of August because the code handles only up to "4 weeks ago" (i.e. 28 days) correctly. Patch attached.

2) In my opinion the aggregation code is somewhat to aggressive in grouping messages in large aggregations. E.g. At the beginning of the week I am usually very interested in the mails I have not yet handled completely which arrived at the end of the previous week. But e.g. today (Tue, 2009-09-01) these are lumped in an big "August" aggregation. The attached patch always groups the last seven days in individual aggregations (by day).

Comment 1 A. Pfaller 2009-09-01 11:18:49 UTC

Created attachment 36609 [details]
Fix for the previously described problems

Comment 2 Thomas McGuire 2009-09-06 20:42:12 UTC

Thanks for the patch, I committed it in revision 1020611, see http://websvn.kde.org/?view=rev&revision=1020611.

The patch will be part of KDE 4.4 (can't be in KDE 4.3.2 since it has a string change)

Please use reviewboard for your next patch, see http://techbase.kde.org/Contribute/Send_Patches#Reviewboard. Otherwise it is easy for patches to get lost.