Bug 204816

Summary:	Messages to be in a singular/plural forms
Product:	[Applications] akregator	Reporter:	OsamaK <osamak.wfm>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:

Description OsamaK 2009-08-23 00:53:42 UTC

Version:            (using Devel)
Installed from:    Compiled sources

The messages:
src/feedpropertieswidgetbase.ui:112 -> Minutes
src/feedpropertieswidgetbase.ui:117 -> Hours
src/feedpropertieswidgetbase.ui:122 -> Days

need to be in singular/plural forms to give a better language.

Comment 1 OsamaK 2009-08-23 00:59:27 UTC

Also, please change these two messages to be one singular/plural form:

src/feedpropertieswidgetbase.ui:269  -> 1 article
configuration/settings_archive.ui:70 ---^

src/feedpropertieswidgetbase.ui:272  -> articles
configuration/settings_archive.ui:73 ---^

Comment 2 OsamaK 2009-08-23 01:01:06 UTC

Also this one:

src/feedpropertieswidgetbase.ui:299 -> 1 day
configuration/settings_archive.ui:106 --^

src/feedpropertieswidgetbase.ui:302 -> days
configuration/settings_archive.ui:109 --^

Comment 3 Christophe Marin 2010-12-01 15:28:12 UTC

Can you check whether everything was fixed please ?

afaics:

# grep i18np feedpropertiesdialog.cpp 
    updateComboBox->setItemText(FeedPropertiesWidget::Minutes, i18np("Minute", "Minutes", value));
    updateComboBox->setItemText(FeedPropertiesWidget::Hours, i18np("Hour", "Hours", value));
    updateComboBox->setItemText(FeedPropertiesWidget::Days, i18np("Day", "Days", value));
    widget->updateComboBox->insertItem(FeedPropertiesWidget::Minutes, i18np("Minute", "Minutes", 0));
    widget->updateComboBox->insertItem(FeedPropertiesWidget::Hours, i18np("Hour", "Hours", 0));
    widget->updateComboBox->insertItem(FeedPropertiesWidget::Days, i18np("Day", "Days", 0));
    widget->sb_maxArticleAge->setSuffix(ki18np(" day", " days"));
    widget->sb_maxArticleNumber->setSuffix(ki18np(" article", " articles"));

Comment 4 OsamaK 2010-12-01 15:47:15 UTC

Thank you, Christophe.

I'm not a C++ developer and I don't know if that solves the issue. Did you update the gettext file so I can check?

Comment 5 Christophe Marin 2010-12-11 00:03:32 UTC

These strings were fixed in August. Looks like all the errors you reported are resolved with this commit:

http://websvn.kde.org/?revision=1010326&sortby=date&view=revision is the revision

It's safe to close this report now :)