Bug 200013

Summary:	Pager in vertical panel is broken
Product:	[Unmaintained] plasma4	Reporter:	Martin Flöser <mgraesslin>
Component:	widget-pager	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	Dhraak, kde, kde, laidig, lucas, mattias
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Martin Flöser 2009-07-13 11:42:38 UTC

Version:            (using Devel)
Installed from:    Compiled sources

When changing to a vertical panel the pager is kind of broken.

Steps to reproduce:
1.) Horizontal panel, 4 desktops, 1 row, 4 columns
2.) change to vertical panel
 new layout: 1 column, 4 rows
 expected layout: 4 columns, 1 row
3.) open pager settings
 -> it says columns instead of rows (that's ok)
 -> tooltip is still "Change number of rows" (that's not ok)
 -> Number of columns is "1" (correct to behaviour of number 2)
4.) change to 4 columns and accept
 result: no change in layout
 expected result: 4 columns, 1 row
5.) open pager settings again
 -> number of columns is still 1 (but was changed to 4 in step 4)
6.) click ok without changing anything
 result: change to 4 columns in pager
 expected result: no change
7.) open pager settings
 -> number of columns is 4
8.) click ok without changing anything
 result: reset of pager layout to 1 column and 4 rows
 expected result: no change

Comment 1 Martin Flöser 2009-07-13 14:15:12 UTC

oh if you don't want to fix this in pager plasmoid you could start adding the code to the desktop kcm. As that probably can't know the orientation of all pagers it would not matter and there would only be rows. Probably the better way ;-)

Comment 2 mattias 2009-07-24 14:03:27 UTC

I have a pager in a vertical panel. When I set "Number of columns" to 1, I get all 8 desktops in single row. When I then open the settings again "Number of columns says" has changed to 8. If I then apply the settings with 8 the pager uses only 1 column but the size of it is to small, I only se one whole desktop and the top of the second below it.
It seems to me that when applying the settings columns are, in my vertical pager, used as rows. But when the settings are read to show the settings dialog it is read as columns. And maybe the size-problem is unrelated?

I am using 4.3 RC3 on OpenSuse 11.1.

Comment 3 Rolf Eike Beer 2009-07-24 19:41:12 UTC

Same here. It should have 2 columns and 5 rows. When it really shows 2 colums it only has the height for 2 rows so >50% of it are not visible at all: I see the first 4 workspaces and some 5 pixels of 5/6. Was working better in rc2.

Comment 4 Dhraak 2009-07-27 01:19:16 UTC

I too ran into this after upgrading to 4.3rc3 from rc2 on OpenSUSE 11.1.

I also saw symptoms of bug #193755 while I was fiddling around trying to get the pager to display properly.  Are they related?

Comment 5 Marco Martin 2009-08-17 20:47:08 UTC

*** Bug 204164 has been marked as a duplicate of this bug. ***

Comment 6 Rolf Eike Beer 2010-01-25 19:43:38 UTC

Works for me in 4.4rc1. Any objections on closing this?

Comment 7 mattias 2010-01-25 22:43:58 UTC

I have no objections, works fine for me now. Good work!!

Comment 8 Rolf Eike Beer 2010-01-26 08:13:25 UTC

Fixed in 4.4