| Summary: | When clicking on "My Tags", the view switches automatically after 2 seconds | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Andi Clemens <andi.clemens> |
| Component: | Albums-MainView | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 1.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 1.0.0 | |
| Sentry Crash Report: | |||
| Attachments: | A quickfix for this issue | ||
|
Description
Andi Clemens
2009-07-09 23:40:13 UTC
Created attachment 35222 [details]
A quickfix for this issue
This patch fixes the issue.
I disabled these connections and still the view seems to behave like it should.
Filtering works as well as adding and removing images.
Why do we need those connections?
When I change to a tag folder, these connections are called over 100 times, with a single click!
This seems to be wrong in my eyes, looks like some race-condition.
Maybe this would also explain the flickering some people seem to encounter.
Marcel,
could it be that these connections are done in another way somewhere else in the code?
Right now I see no malfunction when removing them.
Andi
Hmm no the "selectionChanged" connection needs to be active, otherwise the edit button is disabled. But then I have the issue again that was described in the original report. Ok I found the problem. Somehow if the tag album root is used, we try to display this root album, in a recursive way. This is why we see the welcome page and then some images after a second. I will commit a little patch now, hope this is the right place where the problem should be fixed. Andi SVN commit 994420 by aclemens: Do not start a list job if the album is a root album. This prevents the tag view to display all tags recursively, if "tag subalbums" option is set. BUG:199617 M +3 -0 imagealbummodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=994420 |