| Summary: | Do not show brightness controls if the modules allowing it are not properly installed (empty /sys/class/backlight/) | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Dima Ryazanov <dima> |
| Component: | widget-battery | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | andresbajotierra, aseigo, drf, ervin, zajec5 |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.5.0 | |
| Sentry Crash Report: | |||
|
Description
Dima Ryazanov
2009-07-09 08:39:25 UTC
Just wanted to confirm: I was missing the drivers, and it works correctly after I installed them. Still, I think it's a bug that the slider is there when the drivers are missing. What do you mean by "drivers" ? Which ones? some kernel modules related to power ? Thanks Yes, I was missing the "nvidia_bl" kernel module. I've this implemented locally for KDE 4.4.4. Just have to checkout trunk and port my patch. Rafał: awesome :) can you post the resulting patch to reviewboard.kde.org when you do so? (or you could just post the patch as-is to plasma-devel if you aren't going to get to the porting-to-trunk anytime soon) SVN commit 1157703 by rmilecki: Drop unused Battery::setFullBrightness() CCBUG: 199520 M +0 -6 battery.cpp M +0 -1 battery.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1157703 SVN commit 1157711 by rmilecki: Backport 1157703: drop unused Battery::setFullBrightness() This is needed for bug 199520 fix. CCBUG: 199520 M +0 -6 battery.cpp M +0 -1 battery.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1157711 SVN commit 1157714 by rmilecki: Control any amount of brightness devices Ship it! by Sebastian Kügler: http://reviewboard.kde.org/r/4796/ GUI: BUG: 199520 M +46 -23 battery.cpp M +8 -3 battery.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1157714 SVN commit 1157716 by rmilecki: Backport 1157714: Control any amount of brightness devices Ship it! by Sebastian Kügler: http://reviewboard.kde.org/r/4796/ GUI: BUG: 199520 FIXED-IN: 4.5.0 M +46 -23 battery.cpp M +8 -3 battery.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1157716 SVN commit 1158799 by sebas: Revert r1157716: control amount of brightness sliders This patch produces 4 sliders on my machine (thinkpad T60). As 4 sliders on OK machines are worse than 1 slider We have to revert it for now until we find a proper solution for it. I don't see anything I'd happily commit to the stable branch, so I'll backport this one and we'll let the bug in until we have something that works *and* doesn't break machines that are otherwise OK. CCBUG:199520 CCMAIL:zajec5@gmail.com M +23 -46 battery.cpp M +3 -8 battery.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1158799 SVN commit 1158800 by sebas:
Revert r1157716: control amount of brightness sliders
This patch produces 4 sliders on my machine (thinkpad T60).
As 4 sliders on OK machines are worse than 1 slider We have to revert it
for now until we find a proper solution for it. I don't see anything I'd
happily commit to the stable branch, so I'll backport this one and we'll
let the bug in until we have something that works *and* doesn't break
machines that are otherwise OK.
CCBUG:199520
CCMAIL:zajec5@gmail.com
Dirk, any way we can get this one into 4.5.0 still? (It was about time that I'd
be the one coming with last minute screw-ups and asking everybody to re-roll.
Sorry, really. :/)
CCMAIL:release-team@kde.org
M +23 -46 battery.cpp
M +3 -8 battery.h
WebSVN link: http://websvn.kde.org/?view=rev&revision=1158800
|