Summary: | Add bidirectional text support in default profile | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Zayed Al-Saidi <zayed.alsaidi> |
Component: | general | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ebrahim, elcuco, osamak.wfm |
Priority: | NOR | Keywords: | rtl |
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 4.8 | |
Attachments: | Summary: Konsole BiDi rendering enabled by default |
Description
Zayed Al-Saidi
2009-06-28 14:48:36 UTC
I disagree. If you do this, you will break console applications which have BiDi support. Well, I would not want to have this as default "for me" at least... :) @Diego: Is there any console application that support BiDi by default? I think the majority of console applications luck BiDi support. The standard way of handling BiDi text, according to Unicode, is the way Konsole works when BiDi is turned on. So I think it should be enabled by default. And if somebody uses a non-standard application which handles BiDi in some other way, he can still turn off this part of standard. On the other hand, as a Persian (RTL language) full-time Debian user for years, I haven't heard aobut any non-standard BiDi application yet. They might exist, but my point is they are rare if any. Created attachment 47493 [details] Summary: Konsole BiDi rendering enabled by default Make Konsole BiDi rendering enabled by default. Default Shell.profile and also fallback profile are updated to have BidiRenderingEnabled set to true by default. In reviewboard: http://reviewboard.kde.org/r/4181/ Git commit e718e93bf0caa524c99cd4578c1932db945a3d7f by Kurt Hindenburg. Committed on 19/11/2011 at 21:46. Pushed by hindenburg into branch 'master'. Add bidirectional text support by default Make Konsole BiDi rendering enabled by default. Default Shell.profile and also fallback profile are updated to have BidiRenderingEnabled set to true by default. AFAIK there is no reason not to have it on by default. I don't see any penalty code-wise. BUG: 198169 FIXED-IN: 4.8 M +2 -1 data/profiles/Shell.profile M +1 -1 src/Profile.cpp http://commits.kde.org/konsole/e718e93bf0caa524c99cd4578c1932db945a3d7f |