| Summary: | Ctrl+Tab don't switch over edited files | ||
|---|---|---|---|
| Product: | [Applications] krusader | Reporter: | Tom <english.tom> |
| Component: | krviewer | Assignee: | Nikita Melnichenko <nikita+kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | clearmartin, jan_lepper, keepun, mg, mhlavink, miroslav.milanovic, nikita+kde, psbkde, toni.asensi |
| Priority: | NOR | ||
| Version: | 2.3.0-beta1 "New Horizons" | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/krusader/26c4b148a18bbd6ccce69dd5dbbaf86a471f9cc5 | Version Fixed In: | |
|
Description
Tom
2009-06-09 10:25:04 UTC
*** Bug 375797 has been marked as a duplicate of this bug. *** This issue is still reproducible with my build from Git master (Krusader 2.5.1-beta, revision 5056272). Temporary workaround is to set KrViewer Shortcuts explicitly for changing tabs to Ctrl+Tab and Ctrl+Shift+Tab. But on Arch linux this is working fine without a need for these changes. My guess (not tested) would be that this is fixed in newer versions of KF5. I have KF 5.30 on Arch linux now. Wladimir, can you please re-test this issue on your newer Ubuntu 16.10? I did and the issue is still reproducible on Ubuntu 16.10 (KF 5.26). The issue is also reproducible on Kubuntu 16.10 (KF 5.26). Hello, As far as I know Krusader uses the standard settings for changing tabs. Please check your system settings (https://userbase.kde.org/System_Settings/Shortcuts_and_Gestures#Standard_Keyboard_Shortcuts) what shortcut is defined there and change it when needed. Therefor, I think this is not a bug. Best regards For me, the problem isn't the keyboard shortcut settings. The keyboard shortcut works just fine as long as you are merely viewing files. If you are editing them however, Kate will handle Ctrl-Tab itself and insert a tab into the text. (In reply to Wladimir Palant from comment #7) > For me, the problem isn't the keyboard shortcut settings. The keyboard > shortcut works just fine as long as you are merely viewing files. If you are > editing them however, Kate will handle Ctrl-Tab itself and insert a tab into > the text. Hi, maybe I did not got your point, sorry. I can confirm that Ctrl-Tab changes the tab while viewing a file but - at least using Tumbleweed - the default shortcut (see comment above) for changing tabs is CTRL-, and CTRL-. These shortcuts are working fine for me when editing a file. Have you changed the default shortcuts to CTRL-TAB? BR It seems that you are right, changing the Lister's keyboard shortcut settings makes Ctrl+Tab work both when viewing and editing. Then I wonder why it isn't the default, that's quite unexpected. For reference, I'm on Ubuntu so I wouldn't know how to access KDE's global keyboard shortcut settings. The Lister's local shortcut configuration works however. I also confirm. KrViewer works fine if all tabs are Lister or other read-only mode tabs. If there are Editor tabs, you can switch between tabs normally until it switches to an Editor tab where Ctrl+Tab and Ctrl+Shift+Tab seem to be captured by Katepart. I looked at shortcuts in KrViewer, it shows Ctrl+Pagedown as primary shortcut for Next Tab and Ctrl+] as Alternate (Global and Global Alternate are empty) - this must be default settings as I didn't change them previously. Ctrl+Pagedown claims itself as ambiguous (don't really understand why). Ctrl+] works fine for all tabs. Does it mean we don't officially support Ctrl+Tab in Krusader? > Does it mean we don't officially support Ctrl+Tab in Krusader?
I believe so. I checked again on my Arch linux and it seems the behaviour is the same as for everyone here. When using default settings, Ctrl+tab inserts a tab in editor. (So my previous comment was wrong, my apologies.)
This issue is either a modification request - if we agree on that, we can change the default keyboard bindings of KrViewer. Or it a resolved-invalid since changing tabs in KrViewer works correctly according configured shortcuts.
My personal opinion is we should change the default settings to Ctrl+Tab and Ctrl+Shift+Tab.
+1 for making Ctrl+Tab and Ctrl+Shift+Tab as primary shortcuts in KrViewer. > > My personal opinion is we should change the default settings to Ctrl+Tab and Ctrl+Shift+Tab.
> > [...]
> +1 for making Ctrl+Tab and Ctrl+Shift+Tab as primary shortcuts in KrViewer.
I also consider that this is the best idea. Thanks!
Git commit 26c4b148a18bbd6ccce69dd5dbbaf86a471f9cc5 by Nikita Melnichenko. Committed on 24/02/2018 at 05:50. Pushed by melnichenko into branch 'master'. KrViewer: reenforce QTabWidget shortcuts for tab switching FIXED: [ 195749 ] Ctrl+Tab don't switch over edited files Ctrl+Tab and Ctrl+Shift+Tab are actually default QTabWidget shortcuts that are implemented via keyPressEvent method. When editor is placed on a tab, it intercepts the key presses for itself. This is why KrViewer understands the shortcuts fine if all tabs are Lister or other read-only tabs. If there are Editor tabs, you can switch between tabs normally until you hit an Editor tab and then it acts as Tab and Shift+Tab correspondingly. This change enforces the shortcuts through KActionCollection::setDefaultShortcuts which take precedence over the editor shortcuts. Differential Revision: https://phabricator.kde.org/D10734 M +9 -3 krusader/KViewer/krviewer.cpp https://commits.kde.org/krusader/26c4b148a18bbd6ccce69dd5dbbaf86a471f9cc5 |