Bug 195717

Summary:	'KXMLGUIFactory::refreshActionProperties' does not honour default shortcuts for actions that were created after GUI setup
Product:	[Unmaintained] kdelibs	Reporter:	Michel Ludwig <michel.ludwig>
Component:	shortcuts	Assignee:	kdelibs bugs <kdelibs-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	amunkres, faure, thomas.braun
Priority:	NOR
Version:	SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.6
Sentry Crash Report:

Description Michel Ludwig 2009-06-08 23:11:48 UTC

Version:            (using Devel)
Installed from:    Compiled sources

The default shortcut for actions that are set up after the GUI has been created (with XMLGUI) will lose the default shortcut setting after a call to 'KXMLGUIFactory::refreshActionProperties'.

It seems that 'KXMLGUIFactoryPrivate::saveDefaultActionProperties' is only called in 'KXMLGUIFactory::addClient'. Later changes to shortcuts (or actions that are created later) are not taken into account.

Comment 1 David Faure 2010-10-19 22:25:33 UTC

*** Bug 173563 has been marked as a duplicate of this bug. ***

Comment 2 David Faure 2010-10-19 22:36:33 UTC

SVN commit 1187590 by dfaure:

Load custom shortcuts for dynamic actions (plugActionList) as well.
This makes it possible to set a shortcut for khtml's "Display Images on Page" (bug 173563)
or for "switch to view mode Cervisia" (Rigo Wenning's request).

FIXED-IN: 4.6
BUG: 195717


 M  +2 -0      kxmlguiclient.h  
 M  +47 -45    kxmlguifactory.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1187590