Bug 195711

Summary:	Desktop settings doesn't allow to choose the wallpaper twice
Product:	[Unmaintained] plasma4	Reporter:	Einar Lielmanis <einars+kdebugs>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aseigo
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Possible patch

Description Einar Lielmanis 2009-06-08 22:35:16 UTC

Version:           svn:978887 (using Devel)
Installed from:    Compiled sources

1. open desktop settings
2. choose any wallpaper from the disk (using file chooser icon)
3. dislike the wallpaper
4. choose another wallpaper from the disk (again, using the file chooser icon)
5. observe that the wallpaper doesn't change, the image stays the same and the new file is ignored.

The problem lies in kdebase/workspace/plasma/wallpapers/image/image.cpp and lies in the fact that browse() which gets called on choosing the file removes the okClicked() signal from the dialog, which doesn't get reconnected on dialog reuse. See attached patch.

Comment 1 Einar Lielmanis 2009-06-08 22:36:23 UTC

Created attachment 34377 [details]
Possible patch

I don't know the reason for removing the signal in the first place.

Comment 2 Aaron J. Seigo 2009-06-09 01:05:12 UTC

thanks for the patch; http://reviewboard.kde.org is usually a better place for plasma patches ...

Comment 3 Aaron J. Seigo 2009-06-09 01:05:25 UTC

SVN commit 979110 by aseigo:

remove an errant disconnect; improve the readability while i'm in here with a better method name than "browse()"
BUG:195711


 M  +3 -3      image.cpp  
 M  +1 -1      image.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=979110