| Summary: | Regressions in interface What's This coverage & other missing strings | ||
|---|---|---|---|
| Product: | [Applications] konversation | Reporter: | Eike Hein <hein> |
| Component: | general | Assignee: | Konversation Developers <konversation-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | Git | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Bug Depends on: | |||
| Bug Blocks: | 187307 | ||
| Attachments: | Missing strings vs. the KDE 3 version. | ||
SVN commit 967742 by pino: - put back accelerators and buddies for labels, as they were in kde3's version - remove extra markup - put back some tooltips and whatsthis - (correctly) fix few strings, also to match their kde3 equivalents CCBUG: 192500 M +73 -29 identitydialog.ui M +4 -1 irc/serverlistdialogui.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=967742 SVN commit 967746 by pino: re-add whatsthis CCBUG: 192500 M +5 -1 servergroupdialogui.ui WebSVN link: http://websvn.kde.org/?view=rev&revision=967746 SVN commit 967748 by pino: set again the suffix for the inactivity time spinbox, doing the right thing if using kde 4.3 CCBUG: 192500 M +7 -0 identitydialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=967748 All the messages that were untouched since KDE 3 were saved correctly to the KDE 4 version. commit 932a9f7b8c19b2a13892f05439ca71ac843cd766 Author: Pino Toscano <pino@kde.org> Date: Wed May 13 21:53:40 2009 +0000 set again the suffix for the inactivity time spinbox, doing the right thing if using kde 4.3 CCBUG: 192500 svn path=/branches/work/konvi-kde4/; revision=967748 diff --git a/src/identitydialog.cpp b/src/identitydialog.cpp index fbc0ac8..585887a 100644 --- a/src/identitydialog.cpp +++ b/src/identitydialog.cpp @@ -54,6 +54,13 @@ namespace Konversation // add encodings to combo box m_codecCBox->addItems(Konversation::IRCCharsets::self()->availableEncodingDescriptiveNames()); + // set the suffix for the inactivity time spinbox +#if KDE_IS_VERSION(4, 2, 80) + m_awayInactivitySpin->setSuffix(ki18np(" minute", " minutes")); +#else + m_awayInactivitySpin->setSuffix(i18n(" minutes")); +#endif + // set values for the widgets updateIdentity(0); |
Created attachment 33597 [details] Missing strings vs. the KDE 3 version. During the porting to KDE 4, a whole bunch of strings (mostly "What's This" help tooltips) got lost. These need to be added back before we can move from /branches/work to /trunk/extragear to minimize issues with auto-merging existing translations from the KDE 3 version. Attached is a list of all missing strings.