Bug 189984

May be Kipi-plugins 0.2.0-beta2 solves the bug:

SendImages : Complete re-write of emailing tool.

Which kipi-plugin you use ?

Gilles Caulier

(In reply to comment #2)
> Which kipi-plugin you use ?
> 
> Gilles Caulier

In fact I use 'Send Images - Kipi-plugins 0.2.0' so forget my previous comment...

confirming in KMail with current trunk

Is it ok to commit ?  for me this fixes the issue

Index: sendimages/sendimages.cpp
===================================================================
--- sendimages/sendimages.cpp   (révision 992427)
+++ sendimages/sendimages.cpp   (copie de travail)
@@ -389,7 +389,7 @@
                     for (KUrl::List::ConstIterator it = fileList.constBegin() ; it != fileList.constEnd() ; ++it )
                     {
                         args.append("-a");
-                        args.append(QFile::encodeName((*it).path()));
+                        args.append((*it).path());
                     }

                     if (!QProcess::startDetached(prog, args))
@@ -412,7 +412,7 @@
                     args.append("--attach");
                     for (KUrl::List::ConstIterator it = fileList.constBegin() ; it != fileList.constEnd() ; ++it )
                     {
-                        args.append(QFile::encodeName((*it).path()));
+                        args.append((*it).path());
                     }

                     QString prog;
@@ -442,7 +442,7 @@
                     for (KUrl::List::ConstIterator it = fileList.constBegin() ; it != fileList.constEnd() ; ++it )
                     {
                         tmp.append("&attach=");
-                        tmp.append( QFile::encodeName((*it).path()) );
+                        tmp.append( (*it).path() );
                     }
                     args.append(tmp);

@@ -464,7 +464,7 @@
                     for (KUrl::List::ConstIterator it = fileList.constBegin() ; it != fileList.constEnd() ; ++it )
                     {
                         args.append("--attach");
-                        args.append(QFile::encodeName((*it).path()));
+                        args.append((*it).path());
                     }

                     if (!QProcess::startDetached(prog, args))

gilles what do you think of this patch ?

*** Bug 158916 has been marked as a duplicate of this bug. ***

The question is : why something like QFile::encodeName() do not exist to handle UTF-8 char encoding ?

http://doc.trolltech.com/4.5/qfile.html#encodeName

If you grep this method in kipi-plugins/digiKam/libkdcraw/libkexiv2, you will see that it's used everywhere to handle file name.

I remember some problem With qt3 to pass QString as well to handle file name. perhaps iy's obsolete now with QT4.

To resume, this will not limited to patch SendImages plugin in this way. If i remember, there are other bug report like this in Bugzilla...

Gilles Caulier

but here this is KUrl that are used and they are already encoded as the API tells :

Constructor taking a char * urlOrPath, which is an _encoded_ representation of the URL, exactly like the usual constructor. 
This is useful when the URL, in its encoded form, is strictly ascii.

SVN commit 994087 by nlecureuil:

SendImage: Add A warning when a file is too big to be sent
SendImage: Do not encode file name as KUrl already does this
BUG:146487
BUG:189984 


 M  +12 -6     sendimages.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=994087

This problem is not reproducible with new Send By Mail tool from digiKam core
version 5.7.0.

Gilles Caulier