| Summary: | Default playlist layout names are not translatable | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Albert Astals Cid <aacid> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | aspotashev, cycoone, ian.monroe, kfunk, lfranchi, nhn, yurchor |
| Priority: | HI | ||
| Version: | 2.3-GIT | ||
| Target Milestone: | 2.3.0 | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch to fix l10n for playlist layouts
Part of "amarok --debug" output on layouts |
||
|
Description
Albert Astals Cid
2009-04-15 22:37:44 UTC
See http://techbase.kde.org/Development/Tutorials/Localization/Building_KDE's_l10n_Module for how to use the x-test language for testing My suggestion: * Add to the xml a attribute that is default="true" for the ones that are shipped by default * Add to Messages.sh a way to parse the XML and extract the default values and store it in rc.cpp * When showing the layout name, check if it has the default="true" tag, if it has it, you pass the layout name thorugh i18n, if it has not, you just show it * User created layouts have default="false" * If a user edits a default layout it stops being a default layout so default goes to false too. Ian: I seem to remember you saying something about Plasma devs having a fix for this. Can you please comment? Any news about this? Bumb. This is old, could somebody comment on this, please? commit 5300a8328e1b0f9e90e95ff72e450e11b4c18447 Author: Kevin Funk <krf@electrostorm.net> Date: Sun Oct 18 22:39:43 2009 +0200 Make playlist layouts translatable BR: 189751 Just before string freeze ;) That bug really doesn't fix the bug, thanks for working on it though :-) Our ChangeLog claims that this bug was fixed. KRF, what gives? No, it is not fixed. Today's git build, Ukrainian, 100% translated. All layout names and fields are in English: http://omploader.org/vMm50dQ/amarok.png So Kevin, what did your patch actually do then? :) Maybe it should be reverted and the ChangeLog entry removed as well. Mark, my commit made it possible to translate the strings. However, the translated strings are not used in Amarok itself. The bug is not fixed yet, yep. Created attachment 38010 [details]
Patch to fix l10n for playlist layouts
Try to use the translated strings in Amarok.
Please test the attached diff as my l10n setup is horribly broken and cant test it locally. Please make sure the strings are already translated (check po file, etc.)
Created attachment 38011 [details]
Part of "amarok --debug" output on layouts
Applied to the last git-version (Ukrainian translation - messages 1389-1392 (layout names) are translated). Playlist is completely gone. All layout names ("Default", "No grouping", "Verbose") are gone as well. Only my own layout ("My") can be viewed in the list.
Screenshot:
http://omploader.org/vMm82dw/amarok1.png
Part of the debug output attached.
Okay. No idea then, maybe Nikolaj has an idea how to work around this. Nikolaj? Nikolaj Hald Nielsen (nhn@kde.org) see #189750 (which looks like a dupe to me, but I'm not familiar with the issue) Well spotted, Stephen. *** This bug has been marked as a duplicate of bug 189750 *** |
