Bug 189177

Summary:	konqueror/dolphin: compress context menu should not show rar tar.gz etc inside a read-only-folder
Product:	[Applications] ark	Reporter:	Shriramana Sharma <samjnaa>
Component:	general	Assignee:	Elvis Angelaccio <elvis.angelaccio>
Status:	RESOLVED FIXED
Severity:	normal	CC:	finex, frank78ac, rakuco
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Unspecified
Latest Commit:	http://commits.kde.org/ark/c369264d6c9ba2763b338f025c359c1b4c86f66e	Version Fixed In:	16.08.0
Sentry Crash Report:

Description Shriramana Sharma 2009-04-09 07:56:50 UTC

Version:            (using KDE 4.2.2)
Installed from:    Ubuntu Packages

Hello. If I go to a read-only folder in either Konqueror or Dolphin and right-click on a file/folder present there, I get a compress context menu. Inside there is a Compress To... menu item which allows me to specify format and location of archive to be created. There are also other items like RAR TAR.GZ etc. These are meant for quick creation of archives of that format (and a default name) in the current directory. 

But since for read-only folders the current directory is not writable, these entries should not be displayed as they will certainly lead to error windows (which is why I think this is a bug and not just a wishlist).

Comment 1 Frank Reininghaus 2009-10-10 11:01:55 UTC

*** Bug 189484 has been marked as a duplicate of this bug. ***

Comment 2 Frank Reininghaus 2009-10-10 11:07:24 UTC

I can confirm the issue.

I'm not sure if that is really a bug in Dolphin/Konqueror. Maybe it's related to the application that provides that context menu action (Ark)?

Comment 3 FiNeX 2009-12-05 17:31:26 UTC

I don't know either if it is a dolphin or an ark issue, anyway dolphin should be a better product than konqui

Comment 4 Raphael Kubo da Costa 2009-12-05 18:28:19 UTC

These options come from Ark, however I'm not sure the .desktop file that provides them can control if they shouldn't be displayed when some conditions are not met (in this case, the directory being writable).

Comment 5 Jeroen van Meeuwen (Kolab Systems) 2012-08-24 16:18:34 UTC

Resetting assignee to default as per bug #305719

Comment 6 Frank Reininghaus 2012-11-29 21:35:09 UTC

Reassigning to Ark - If I'm not mistaken, this can be resolved with actions which are implemented by subclassing KAbstractFileItemActionPlugin.

Comment 7 Elvis Angelaccio 2016-06-05 17:53:35 UTC

Git commit c369264d6c9ba2763b338f025c359c1b4c86f66e by Elvis Angelaccio.
Committed on 05/06/2016 at 17:50.
Pushed by elvisangelaccio into branch 'master'.

Port service menus to KFileItemAction

The Compress and Extract service menus shown in Dolphin's context menu are now
provided by two new KFileItemAction plugins. This allows us to do a lot of
useful checks before actually showing the actions in the context menu.

We can also stop hardcoding the supported mimetypes for the Extract
menu. This is actually required in order to support the Extract menu when more
than one archive is selected. In this case Dolphin sends to the kfileitemaction
plugins the
generic 'application/octet-stream' mimetype, so we have to manually check
anyway the mimetype of any given URL (to be sure that Ark supports it).

This also paves the way to dynamically generate the service menus (e.g. based
on some kind of user preset).
Related: bug 268163, bug 348582
FIXED-IN: 16.08.0

Differential Revision: D1761

M  +22   -6    app/CMakeLists.txt
D  +0    -179  app/ark_addtoservicemenu.desktop
D  +0    -167  app/ark_servicemenu.desktop.cmake
A  +99   -0    app/compressfileitemaction.cpp     [License: GPL (v2+)]
A  +54   -0    app/compressfileitemaction.h     [License: GPL (v2+)]
A  +15   -0    app/compressfileitemaction.json
A  +103  -0    app/extractfileitemaction.cpp     [License: GPL (v2+)]
A  +54   -0    app/extractfileitemaction.h     [License: GPL (v2+)]
A  +13   -0    app/extractfileitemaction.json

http://commits.kde.org/ark/c369264d6c9ba2763b338f025c359c1b4c86f66e