Bug 187475

Summary: Konqueror 4 search doesn't work with frames
Product: [Applications] konqueror Reporter: Artem S. Tashkinov <aros>
Component: generalAssignee: Konqueror Developers <konq-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: ibc, wilderkde
Priority: NOR    
Version: 4.2.1   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Test-case

Description Artem S. Tashkinov 2009-03-18 06:02:18 UTC 
Version:            (using KDE 4.2.1)
OS:                Linux
Installed from:    Fedora RPMs

It's a very annoying bug but Konqueror 4 is unable to find text in pages with <FRAMES>.

A testcase will be attached.
Comment 1 Artem S. Tashkinov 2009-03-18 06:03:33 UTC 
Created attachment 32223 [details]
Test-case
Comment 2 Pino Toscano 2009-03-18 11:06:59 UTC 

*** This bug has been marked as a duplicate of bug 177397 ***
Comment 3 Germain Garand 2009-03-26 02:07:26 UTC 
SVN commit 944738 by ggarand:

.Re-implement search in sub-frames, that was lost when switching to
 the embedded findbar.

 The previous implementation required a frame/iframe to have the focus
 (e.g. by clicking its content) to be able to search it.
 This one will walk frames in document/reverse-document order, searching
 each in turn.

.Fix bug in the search algorithm that would require one two click twice on
 'Previous' to effectively match the previous occurence, if the current
 occurence was the last of the document.

BUG: 187475


 M  +76 -56    find/khtmlfind.cpp  
 M  +3 -1      find/khtmlfind_p.h  
 M  +5 -0      khtml_part.cpp  
 M  +6 -0      khtml_part.h  
 M  +1 -1      khtmlpart_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944738
Comment 4 Germain Garand 2009-03-26 02:48:50 UTC 
SVN commit 944751 by ggarand:

automatically merged revision 944738:
.Re-implement search in sub-frames, that was lost when switching to
 the embedded findbar.

 The previous implementation required a frame/iframe to have the focus
 (e.g. by clicking its content) to be able to search it.
 This one will walk frames in document/reverse-document order, searching
 each in turn.

.Fix bug in the search algorithm that would require one two click twice on
 'Previous' to effectively match the previous occurence, if the current
 occurence was the last of the document.

BUG: 187475

 M  +76 -56    find/khtmlfind.cpp  
 M  +3 -1      find/khtmlfind_p.h  
 M  +5 -0      khtml_part.cpp  
 M  +6 -0      khtml_part.h  
 M  +1 -1      khtmlpart_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=944751
Comment 5 Jacopo De Simoi 2009-03-27 19:41:34 UTC 
this patch causes a crash in konqueror (see bug #188276)
Comment 6 Maksim Orlovich 2009-03-31 21:42:19 UTC 
*** Bug 188568 has been marked as a duplicate of this bug. ***