| Summary: | JJ: Better visibility of "new image from clipboard" functionallity. | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Raúl <rasasi78> |
| Component: | General | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | cberger, fossphreak, halla, matjazrous |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/calligra/c78c598981b71c490f819bd879e3ccff5531b1c5 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Proposed solution
Improvement Improved GUI |
||
|
Description
Raúl
2009-03-16 12:44:27 UTC
Forget about my comment on create a new bug. The plan would be to have a the "new image from clipboard" outside the "custom document" widget, it would be an icon on the left, and offer something like a preview of what is in the clipboard, and possibely offer the option to select a profile. Yes, that would be best. But I doubt we'll get a patch to make that possible into the libraries. Marking as junior job, it's already possible to do it in library, just add a widget to the list: QList<KoDocument::CustomDocumentWidgetItem> KisDoc2::createCustomDocumentWidgets(QWidget *parent) Might be worth to have them available as plugins, but for the JJ, adding the widget to that inside kritaui would be sufficient. Does this still need to be done? If not, I can work on it. Yes, it still needs to be done. And it would be wonderful if you would work on it! If you have any questions or want help to get started, join us on #krita on irc.freenode.net or the kimageshop@kde.org mailing list. I had been working on this off and on, and I had made some progress. But, my hard drive (or atleast the partition) seems to be corrupted and it's difficult to recover what was lost. I thought I could use git to recover the files, but it looks like several files in the git repository are corrupted/empty. So, I'll probably have to start all over. :(. If anyone else has been working on this, or was planning to, it's better and probably faster if they go ahead and do it. Created attachment 79589 [details]
Proposed solution
I worked on this over the last couple of days and managed to solve the issue.
Thanks, I'll test it tonight/early tomorrow! Created attachment 79722 [details]
Improvement
Improved version of the patch.
Created attachment 79723 [details]
Improved GUI
Small GUI improvement.
Hi Matjaž, I'm trying to apply your patch but running into lots of trouble. Could you attach the files you touched to the bug so I can make a new diff myself? Thanks! Git commit 1723decc4b8f5ba51a79b836f1d3064d48d20077 by Boudewijn Rempt. Committed on 11/05/2013 at 14:14. Pushed by rempt into branch 'master'. Move create image from clip to a separate widget Patch by Matjaž Rous CCMAIL: matjazrous@gmail.com M +1 -0 krita/ui/CMakeLists.txt M +21 -19 krita/ui/forms/wdgnewimage.ui M +21 -9 krita/ui/kis_part2.cpp M +16 -53 krita/ui/widgets/kis_custom_image_widget.cc M +14 -6 krita/ui/widgets/kis_custom_image_widget.h A +150 -0 krita/ui/widgets/kis_image_from_clipboard_widget.cpp [License: GPL (v2+)] A +55 -0 krita/ui/widgets/kis_image_from_clipboard_widget.h [License: GPL (v2+)] http://commits.kde.org/calligra/1723decc4b8f5ba51a79b836f1d3064d48d20077 Git commit c78c598981b71c490f819bd879e3ccff5531b1c5 by Siddharth Sharma, on behalf of Boudewijn Rempt. Committed on 11/05/2013 at 14:14. Pushed by siddharthsharma into branch 'krita-psd-plugin-siddharth'. Move create image from clip to a separate widget Patch by Matjaž Rous CCMAIL: matjazrous@gmail.com M +1 -0 krita/ui/CMakeLists.txt M +21 -19 krita/ui/forms/wdgnewimage.ui M +21 -9 krita/ui/kis_part2.cpp M +16 -53 krita/ui/widgets/kis_custom_image_widget.cc M +14 -6 krita/ui/widgets/kis_custom_image_widget.h A +150 -0 krita/ui/widgets/kis_image_from_clipboard_widget.cpp [License: GPL (v2+)] A +55 -0 krita/ui/widgets/kis_image_from_clipboard_widget.h [License: GPL (v2+)] http://commits.kde.org/calligra/c78c598981b71c490f819bd879e3ccff5531b1c5 |