Bug 186823

Summary:	several bugs in lens defect auto-correction tool
Product:	[Applications] digikam	Reporter:	Matthias Welwarsky <matze>
Component:	Plugin-Editor-LensCorrection	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	caulier.gilles, marcel.wiesweg
Priority:	NOR
Version:	0.10.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:	1.0.0
Attachments:	proposed patch to fix the mentioned bugs updated patch patch without tabs

Description Matthias Welwarsky 2009-03-10 23:23:20 UTC

Version:           svn r937541 (using KDE 4.2.1)
OS:                Linux
Installed from:    Ubuntu Packages

chromatic aberration correction does not work:
- resulting image is transparent (alpha == 0)
- involves sub-pixel movements of color components, which is not implemented

distortion correction creates artifacts
- involves sub-pixel movements of image data, which is not implemented

Comment 1 Matthias Welwarsky 2009-03-10 23:27:23 UTC

Created attachment 32009 [details]
proposed patch to fix the mentioned bugs

this patch implements access to interpolated image data in class DImg, either via Lanczos or Bilinear interpolation. it also fixes the mentioned bugs in the lens defect auto-correction plugin

Comment 2 Andi Clemens 2009-04-12 22:14:27 UTC

Matthias,

can you update your patch to current trunk? I tried to apply it but it failed.

Andi

Comment 3 Matthias Welwarsky 2009-04-13 16:17:52 UTC

Created attachment 32811 [details]
updated patch

Comment 4 Andi Clemens 2009-04-21 15:03:10 UTC

Created attachment 32985 [details]
patch without tabs

I removed the tabs from the patch.
Sorry I hadn't the time yet to look at the patch, it is quite big.
I guess we need to discuss this further, at least I will not commit it on my own :-)

Gilles, Marcel,

can you take a look at this patch, too?

Andi

Comment 5 Matthias Welwarsky 2009-04-21 15:15:12 UTC

We can meet on IRC if you need real time.

Comment 6 caulier.gilles 2009-04-21 16:13:50 UTC

Yes, patch is huge. Great job.

Marcel, patch touch DImg component indeep. Can you take a look. I will do it also, but it a sensible part...

Gilles

Comment 7 Marcel Wiesweg 2009-04-22 19:50:38 UTC

There are a lot of whitespace changes in the API docs of dimg.h. I think these are a side-product of the patch processing and should be removed from the patch - then it is much smaller.
For me the characters of Ville's surname in the copyright notice are broken as well. Encoding issue.

Other than that, I see a bug fix in blendClamp8() and the rest is added methods, that's fine with me.

Comment 8 caulier.gilles 2009-04-23 10:24:39 UTC

Thanks Marcel. 

I review patch today...

Gilles

Comment 9 caulier.gilles 2009-04-23 13:07:59 UTC

SVN commit 958053 by cgilles:

apply patch #32985 from Matthias Welwarsky fo fix LensFun tool with Lanzcos method
BUG: 186823


 M  +7 -7      imageplugins/lenscorrection/autocorrection/klensfun.cpp  
 M  +1 -0      libs/dimg/dcolor.h  
 M  +16 -9     libs/dimg/dcolorblend.h  
 M  +218 -2    libs/dimg/dimg.cpp  
 M  +96 -80    libs/dimg/dimg.h  
 M  +28 -1     libs/dimg/dimgprivate.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=958053