| Summary: | KPart shows a strange menu after first rightclick in a tab | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | Alessandro Guido <ag> |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | carlosdgtorres, christiandehne, djmatic8, dschulz, etienne.hilson, eugene.shalygin+bugzilla.kde, f3lip3tkd, hein, mail, mick22, mikko.cal, rdieter, realnc, robertknight, sebelk, spatz, tiposchi, toddrpartridge, vitaliy.osypenko, wrar |
| Priority: | NOR | ||
| Version: | CVS | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
good
menu appears menu clicked Patch to test with on trunk |
||
|
Description
Alessandro Guido
2009-03-10 10:48:34 UTC
Created attachment 31978 [details]
good
Created attachment 31979 [details]
menu appears
Created attachment 31980 [details]
menu clicked
As the terminal area and its context menu are provided by the Konsole KPart component which Yakuake embeds (and the Yakuake code also hasn't changed in any relevant way), I'm reassigning this bug to Konsole. FWIW, this is similar to a KXMLGUI-related bug that reared its head in Konsole before. Rename for clarity. (In reply to comment #4) > As the terminal area and its context menu are provided by the Konsole KPart > component which Yakuake embeds (and the Yakuake code also hasn't changed in any > relevant way), I'm reassigning this bug to Konsole. > > FWIW, this is similar to a KXMLGUI-related bug that reared its head in Konsole > before. You're right, dolphin's terminal panel shows the same behaviour. I would like to note, that this strange menu is ordinal Konsole menu, but all top-level items has no text. Also, Oxygen and Skulpture styles does not show that menu at all, whyle all other styles installed on my machine (including Qt styles such as Cleanlooks and so) do. However, they do that in different way: QtCurve draws vertical context menu, Bespin draws usual horizontal menu, Cleanlooks draws series of black rectangles and so on. Personally, I'm seeing this with the Oxygen style as well. I have the same problem in kate and kile. *** Bug 196177 has been marked as a duplicate of this bug. *** *** Bug 197963 has been marked as a duplicate of this bug. *** I just noticed the KPart context menu has changed in 4.3.0; the "Scrollback" sub-menu is missing now. Since I believe this bug here is an XMLGUI issue I think it's related. *** Bug 203390 has been marked as a duplicate of this bug. *** Same problem, right click show tab in left corner. Tested in Dolphin, Kate and Yakuake. Konsole is not affected Same here on Gentoo, KDE 4.3.0. Same here, appeared with 4.3.0. *** Bug 205205 has been marked as a duplicate of this bug. *** Can't someone put the keyword "Yakuake" into the title of this bug? Otherwise I guess more duplicates will continue to flow in... It's not a Yakuake bug. It's in Konsole, and affects any application using the Konsole KPart component (Kate, Dolphin, KDevelop ...). And in Konversation as well (just to add to the growing list of apps hit by this bug). In SessionController.cpp, the following makes konsole part work. I'll have to research this more. Does anyone know if KDE 4.1.x had this issue as well?
//#ifdef KONSOLE_PART
setXMLFile("konsole/partui.rc");
//#else
// setXMLFile("konsole/sessionui.rc");
//#endif
*** Bug 187879 has been marked as a duplicate of this bug. *** (In reply to comment #21) > Does anyone know if KDE 4.1.x had this issue as well? I don't think so. At least there never was a stray menu in Yakuake. Same here on Mandriva 2009.1 Created attachment 36561 [details]
Patch to test with on trunk
This appears to work with Konsole and Konqueror on trunk. The issue (I think) is that the #defines don't work and I'm not sure when they last did.
Let me know if it works for you and of course if there is a better way.
Kurt V. Hindenburg's patch (in comment #25) works here on 4.3.0 with Gentoo. The problem probably relates to the fact that the Konsole part and the main application used to be build separately with no code in a common shared library. I believe this changed so that the shared code is now in libkonsoleprivate. Kurt - I suggest moving the part/application test into an "isKonsolePart()" method or similar and then committing the patch. There might be other #ifdef KONSOLE_PART checks elsewhere in the code which need to be addressed as well. SVN commit 1017600 by hindenburg: Correct KPart issue where the wrong context menu was used and invalid menus were created. BUG: 186745 M +13 -6 SessionController.cpp M +3 -0 SessionController.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1017600 This should be backported to the 4.3 branch. SVN commit 1017603 by hindenburg: Correct KPart issue where the wrong context menu was used and invalid menus were created. CCBUG: 186745 M +13 -6 SessionController.cpp M +3 -0 SessionController.h WebSVN link: http://websvn.kde.org/?view=rev&revision=1017603 Apparently the problem persists, at least in Ubuntu's recently released 4.3.1 packages. Please take a look at the snapshot in http://i27.tinypic.com/2mqmc0n.png I believe my patch was a few days after the tagging of 4.3.1. So you'll have to wait until 4.3.2. I test 4.3.1 in ArchLinux and problem does not exist. I've talked Fedora into adding the patch to their 4.3.1 packages, FWIW. This patch is applied to the 4.3.1 packages in Gentoo. Thanks devs, can confirm fix on Arch linux. *** Bug 206231 has been marked as a duplicate of this bug. *** |
