| Summary: | kdelibs does not build against uclibc due to lack of dn_skipname | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | Ryan Hope <rmh3093> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | normal | CC: | faure, winter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Add dn_skipname if __UCLIBC__ | ||
|
Description
Ryan Hope
2009-02-25 05:07:23 UTC
Created attachment 31626 [details]
Add dn_skipname if __UCLIBC__
This patch allows kdelibs to be built against uclibc...
anything gonna happen with this? this should go into kdefakes and not into kio/misc/kpac additionally, we shouldn't check against _UCLIBC_. we should do a cmake ConfigureCheck for dn_skipname and only compile the fakes version if HAVE_DN_SKIPNAME is 0 please see kdecore/fakes.c, kdecore/kdefakes.h.cmake, and the top-level ConfigureChecks.cmake and make a new patch based on these. thanks, i figured you wanted it in cmake but I am a cmake noob and couldnt figure out how to detect __UCLIBC__ from cmake... I will look at what you suggested and submit a new patch Checking for UCLIBC would be check_symbol_exists(__UCLIBC__ "stdlib.h" HAVE_UCLIBC). But that's the wrong way to go about this. Better check whether dn_skipname is available, and define it in fakes.c if not. That's a more general fix, which will work for all systems that might be missing dn_skipname. So better do this in ConfigureChecks.cmake : check_function_exists(dn_skipname HAVE_DN_SKIPNAME) check_prototype_exists(dn_skipname HAVE_DN_SKIPNAME_PROTO) and then in kdefakes.h.cmake and fakes.c, do like all other functions do there ;) Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? Thank you for helping us make KDE software even better for everyone! Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |