Bug 183831

Summary:	Konsole KPart is padded 3 pixels out of place in Yakuake 2.9.4
Product:	[Applications] konsole	Reporter:	Stephan Sokolow <kde_bugzilla_2>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	hein, keplicz
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Screenshot showing the problem

Description Stephan Sokolow 2009-02-09 21:20:13 UTC

Version:           unknown (using 4.2.00 (KDE 4.2.0), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.25-gentoo-r7-20080501

In any of the bundled themes (not tested with others) in Yakuake 2.9.4, there is a 3-pixel black border around the Konsole KPart in Yakuake. This is most visible with the scrollbar, which no longer connects with the edges of the window.

I'm attaching a screenshot of the problem. (It's set to 100& width and 80% height, but it happens with any dimensions)

Comment 1 Stephan Sokolow 2009-02-09 21:20:58 UTC

Created attachment 31160 [details]
Screenshot showing the problem

Comment 2 Eike Hein 2009-02-09 21:35:04 UTC

This is caused by a change in Konsole.

Comment 3 Stephan Sokolow 2009-02-09 21:43:48 UTC

How so? I don't see this problem with the standalone Konsole application or Konqueror's embedded Konsole window. Is it a true bug in Konsole or merely an API change that could be fixed by copying Konqueror's approach?

Comment 4 Eike Hein 2009-02-09 22:18:57 UTC

It's not an API change. Yakuake's code also didn't change. The KPart seems to have gotten some padding added in the KDE 4.2 development cycle; the same change can be observed in Dolphin's terminal dock window when comparing KDE 4.1 and 4.2, or in Konqueror's terminal pane as well. The thing is, this margin doesn't have its own background color, so when embedding the KPart in a regular UI, the margin is window-colored and thus not noticable. Yakuake's window background is user-configurable and defaults to black, however (a fact relavant to the blending behaviour of translucent Yakuake skins), so it's noticable there. I believe that the KPart shouldn't set this margin in its inner widget hierarchy.

I have notified Robert (Konsole maintainer) about this back in July '08, and he has promised to look into it (and repeated that promise recently), so I remain confident the issue will be addressed.

Comment 5 Eike Hein 2009-02-09 22:22:15 UTC

(Addendum for Yakuake users specifically: A change to the background painting code in Yakuake 2.9.4 also caused splitter handles between terminals to show up in the user-configured window background color. This has since been fixed in SVN, and a side-effect is that the rim/margin this report will now also show up in KDE's regular window background color, just like in Dolphin or Konqueror. However, it still breaks up the Yakuake UI. A 2.9.5 with the background fix, tab DND support and other changes will be released soon; this margin problem, however, needs to be addressed in Konsole's codebase as stated above.)

Comment 6 Eike Hein 2009-02-09 22:23:32 UTC

s/this report/this report is about/, sorry.

Comment 7 Piotr Keplicz 2009-04-02 16:04:09 UTC

Seems to be resolved on KDE 4.2.2 - this additional padding is gone.

Comment 8 Eike Hein 2009-04-02 16:09:49 UTC

Sorry, I forgot about this report. Yes, I fixed this bug in Konsole for KDE 4.2.2. The details can be read in bug #171544 as both problems were caused by the same change in Konsole.