| Summary: | Too intrusive new incoming message notifications | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | albert <alberthilbert> |
| Component: | general | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | kdebugs, kde_bugzilla_2, lamarque, mattr, victor.tn |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
groups multiple notifications from a single contact together
screenshot of 10 notifications from a single user with the patch above applied. updating patch, making an option setting for this feature and code convention fixes |
||
|
Description
albert
2009-01-28 14:16:01 UTC
I've already did something like that but for now it's only my local hack which only works if you use default language (English) in KDE. If anybody's interested patch is here http://kedge.wz.cz/kopete/kopetepopups2.diff .To make it work you have to apply it to kdebase and recompile it. I'll try to make it work as standalone plugin (if it's possible) and with all languages. I wish you good work, Roman. Kopete 3.5 solved this problem by having successive messages queue up behind the first one so, until you clicked "view" or "ignore", you only saw one notification. *** This bug has been confirmed by popular vote. *** Created attachment 31798 [details]
groups multiple notifications from a single contact together
Note: grouping is by account messaging you, not meta-contact.
Created attachment 31799 [details]
screenshot of 10 notifications from a single user with the patch above applied.
Hi, The above patch and screenshot show, what I believe to be an improvement I've made to kopete to group messages from a single contact together in the notification. When a user messages you again and already has a message in the queue, (+ N more messages) will appear in the notification below the existing text, where N is the number of messages queued after the displayed one. I'd really appreciate it if you could go over this patch and consider applying it, this has made a massive improvement for me. Note that this patch depends on my fix to bug 186096 https://bugs.kde.org/show_bug.cgi?id=186096 This fixes updating existing notifications. Created attachment 31806 [details]
updating patch, making an option setting for this feature and code convention fixes
Okay cool my patch for 186096 has been accepted.
I also just improved this patch a fair bit. I cleaned up the code a lot more, followed KDE coding conventions more. Then I made a config option for this new feature so you can turn it on and off to your preference.
Comments: 1. can you post this to reviewboard? :) 2. the new class in libkopete is missing a d-pointer. 3. the new class should be in it's own file, IMO. 4. Why isn't this fixed by making the majority of kopete notifications non-persistant? 1. I'll submit it to the reviewboard once I find out what that is.. and once the patch this depends on is committed.. I'm waiting for my kde svn account to be confirmed. 2. The d pointer is for private data, this class is private to begin with, making the entire class a wrapper that forwards to d could be done, but it seems a bit unnecessary in this case, shall I do that? 3. Yeah I'll put it in it's own file. 4. Personally I prefer to have persistent messages, if I go away for a bit and come back I want to see the messages in the queue rather than have to check kopete all the time, I will make another option to use non-persistent messages. I have to agree with James on point 4. I prefer persistent messages. Besides, I have the kind of friends who sometimes hit enter frequently enough that even non-persistent messages would stack up. What I really want is to just have the behaviour from my old KDE 3.5 setup applied to the new Plasma notifications. James' patch essentially does that. Hi, I've been given an svn account and have committed the patch this relies on now. I've submitted another updated version of this patch to kdereview, I'd be really grateful if someone would look over this. I will add transient notifications with a user-configurable time-out to a separate bug and kdereview session. Thanks, James patch looks fine (as noted on reviewboard). please commit. For the sake of anyone reading this bug, I have committed this patch. I am making another patch to allow the user to configure it so the notifications will vanish after a certain number of seconds after bug 176469 has been fixed and kopete is usable for me again. Then I suggest we close this. The severity of this bug should be anything but wishlist. Together with 182481 it is ruining the experience with IM in KDE. Closing bug as suggested by James. |