Summary: | [PATCH] Tag guessing: Compress/simplify whitespace | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Nicos Gollan <gtdev> |
Component: | Metadata Editing and Reading | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | teo, TheCrasher, unnamedrambler |
Priority: | NOR | ||
Version: | 2.3-GIT | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.3.1 | |
Attachments: | Patch against trunk that introduces tag whitespace simplification |
Description
Nicos Gollan
2009-01-10 01:49:58 UTC
Created attachment 30078 [details]
Patch against trunk that introduces tag whitespace simplification
This adds an option for whitespace simplification to the FilenameLayoutDialog. The inside code uses QString::simplified(). That methos implies stripping, so the UI elements model that interdependency.
Teo, could you please have a look at this patch? Thanks :) There seems to be some recent b0rkage in FilenameLayoutDialog caused by a git-svn commit gone bananas that makes it hard to reliably test and apply the patch. I'd rather wait until we fix the issues before merging this, which will happen ASAP. Casey, as I understand you've been doing some refactoring in FilenameLayoutDialog and related. Could you please check if this is still relevant in light of your planned changes? Just looking at the patch source, it doesn't affect anything I've been working on. However, I will include the patch in my upcoming changes after I test it to ensure it doesn't cause any conflicts. This isn't really relevant anymore is it? Whitespace characters can already be removed easily. Closing based on comment #6 |