Summary: | Icons in mail list too large | ||
---|---|---|---|
Product: | [Applications] kmail | Reporter: | David Nolden <david.nolden.kde> |
Component: | new message list | Assignee: | Szymon Stefanek <pragma> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | |
Priority: | NOR | ||
Version: | 1.11.0 | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
How it looks
How it should look |
Description
David Nolden
2009-01-07 20:13:30 UTC
Created attachment 30013 [details]
How it looks
Created attachment 30014 [details]
How it should look
I can confirm that, although I had to change my font size to 6 in order to notice it... SVN commit 909353 by tmcguire: Don't hardcode the icon size to 16, instead calculate it based on the size hint and pass it around. This allows the icons to be scaled down, which helps with small font sizes. The icons is not made bigger than 16 yet. BUG: 178035 M +143 -87 themedelegate.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=909353 Very good! Is this backported to KDE 4.2? > Very good! Is this backported to KDE 4.2?
I'll backport this this week eventually, during my usual backport+merge work.
SVN commit 913680 by tmcguire: Backport r909353 by tmcguire from trunk to the 4.2 branch: Don't hardcode the icon size to 16, instead calculate it based on the size hint and pass it around. This allows the icons to be scaled down, which helps with small font sizes. The icons is not made bigger than 16 yet. CCBUG: 178035 M +143 -87 themedelegate.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=913680 FYI: In trunk the situation changed a bit, the automatic resizing is gone (it was problematic), the size can now be configured with a spinbox. Just out of interest, why was it problematic, because of performance? > Just out of interest, why was it problematic, because of performance?
No, the icon size wasn't calculated correctly for columns with no text (status columns). That caused various problems.
What about QFontInfo::pixelSize() instead of using the size-hint? An option for this seems kind of exaggerated |