Summary: | Cube desktop not paint in the right location the cube reflection effect | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Javier G. <jagarni1983> |
Component: | compositing | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | schristophe |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: |
cube reflection painted on the wrong place
Compiz example of a cube reflection Move reflection down to touch the cube in its lowest point. |
Description
Javier G.
2008-12-23 22:48:21 UTC
Created attachment 29589 [details]
cube reflection painted on the wrong place
Here is an example of how I see the cube reflection.
Created attachment 29590 [details]
Compiz example of a cube reflection
This is an example of how should be painted rightly the cube reflection, only touching the borders of the real cube.
I'm sorry, I forget to include in the first message what version I'm using of KDE: $kde4-config --version Qt: 4.4.3 KDE: 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)) kde4-config: 1.0 If I remember correctly compiz fusion has several "reflection modes". Created attachment 30126 [details]
Move reflection down to touch the cube in its lowest point.
This patch moves reflection down to touch the cube in its lowest point.
It works with any number of desktops.
Variables addedHeightCoeff1 and addedHeightCoeff2 should be re-counted only when numberOfDesktops, width or height of desktop changes, but I don't know how to do it. So they are re-counted every paintScreen.
Thanks for the patch. I am currently working on cube and the way reflection is done will probably change for 4.3, so I can't say yet if the patch can be used. SVN commit 962205 by graesslin: New cube reflection which moves reflection down to touch the cube in its lowest point. Thanks to Michal Srb for the patch. It' really great. There are two small todos: when mixing manual (mouse) rotation with cursor key rotation or zooming the reflection becomes wrong. FEATURE: 178611 M +15 -1 cube.cpp M +3 -0 cube.h WebSVN link: http://websvn.kde.org/?view=rev&revision=962205 *** Bug 193019 has been marked as a duplicate of this bug. *** |