Bug 178382

I don't understand exactly. please take a screenshot.

Gilles Caulier

Martin,

It's duplicates of #177057 ?

Gilles Caulier

I am not sure if this or the bug in 177057 is a downstream bug. I just updated to KDE unstable (a daily SVN snapshot repository) on Archlinux and now my menu is broken, too.
I removed digikamrc and digikamui files, but it doesn't help. Also the "Find Duplicates" action can be found in the menu now.

Created attachment 29688 [details]
problem in KDE3

taken from a KDE3 session

Created attachment 29689 [details]
problem in KDE4

taken from an completely new KDE4 user and session

I just want to mention that all my other KDE4 apps are working fine, only digiKam shows this strange behavior.
Note: "Find Duplicates" can be found in the Edit-menu now, this is very strange.

Andi

(In reply to comment #3)
> Also the "Find Duplicates" action can be found in the menu now.

in the toolbar...

Created attachment 29692 [details]
updated ui.rc

I removed every action from the digikamui.rc file, so that only the pure skeleton of the file remained.
As you can see, everything is gone, but "Find Duplicates" is still visible in the menu and toolbar.
How is this possible?

After running updatedb I'm pretty sure there is only one digikamui.rc file left on my system:
/usr/share/apps/digikam/digikamui.rc

So there is no chance that a messed up digikamui.rc file is left somewhere else.

Andi

File/Edit/View/Settings/Help looks like a standard KDE menu structure.
The Find Duplicates is pretty interesting. You could grep your system KDE share directory (/usr/share/kde4 for me) and you ~/.kde4 for occurrences of "find_duplicates". You could also try what happens if you change this action's name in digikamapp.cpp: If it disappears then, there is something about this name that causes your problem.

I grepped over

/usr/share/kde4
and
~/.kde4
but nothing.

Only in /usr/share/apps I find this entry (in the digikamui.rc file that is copied when installing from sources).

I really don't understand this. I thought that maybe the config is mixed somehow with the one from KDE3, but I removed digikam 0.9.x and the problem remains. This is weird.

I'll try to rename this, but even if the find_duplicates action goes away, the problem with the duplicate menu entries still exists.

Andi

I renamed the action to a completely different name ("what_is_wronghere"), still the same issue.
I have no clue what to do about this anymore.

 Don't know if this is significant but I noticed that duplicate entries have different accel letters.

SVN commit 903155 by aclemens:

We can't use KStandardAction::Find for three different actions here, it
will mess up the menus and toolbars. Also we need to call
KStandardAction::find(), not ::Find() to customize the standard action,
otherwise we will have duplicate menu entries and the action will appear
in the toolbar.

Gilles, Marcel,

simple search is not focusing / switching to the "search tab" on the left automatically,
so this action is not very useful if the "advanced search" tab is
closed or not displayed at all. It only works if the tab is already
opened.
I think we need to focus the tab automatically, like when using the "Find
similar" action.

CCBUG:178382

 M  +9 -12     digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903155

SVN commit 903156 by aclemens:

Overwrite KStandardActions to avoid duplicate menu entries

CCBUG:178382

++

 M  +6 -6      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903156

The main problem should be fixed now.

Martin,

can you checkout latest SVN trunk and see if everything is fine?

Andi

Hi,

this seems to be partly fixed. The menu entries in album view are now as expected. The top level entry "File" in Edit mode remains duplicate. The first only has "Close" as an entry.The second has the expected entries (navigation, savin, etc.) 

Right, I just checked the main app for those errors. I will go through everything now, LightTable, Editor, showFoto, CameraUI etc... thanks for the hint.

Andi

Martin,

I commited changes to EditorWindow, LightTable and CameraUI right now. I hope I didn't forgot another window :-)
Can you test it?

Andi

Martin,

I will close this one now. I think everything should be fixed. If not, feel free to re-open it again.

Andi

Checked the SVN version of 09/02/01. Indeed, the bug is resolved.