Bug 177925

Summary:	[regression] KHTML part does not accept drop events
Product:	[Applications] konqueror	Reporter:	David Palacio <dpalacio>
Component:	khtml part	Assignee:	Konqueror Developers <konq-bugs>
Status:	CLOSED FIXED
Severity:	normal	CC:	faure, finex, frank78ac, germain, squan
Priority:	NOR	Keywords:	regression
Version:	SVN
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description David Palacio 2008-12-16 21:04:00 UTC

Version:            (using Devel)
Installed from:    Compiled sources

I used to drop an url from another window to the view in Konqueror and it would open. Now it only works on when I drop it on the tab.

Testcase:
1. Open http://kde.org/ on a new window
2. Drop a link to this report view
3. A not-allowed-drop cursor appears

Comment 1 Frank Reininghaus 2008-12-17 23:59:37 UTC

Thanks for the bug report. Confirmed in trunk rev. 898284. Dropping things still works in file management mode, so I think the error is probably in the KHTML part.

Comment 2 FiNeX 2008-12-18 13:47:52 UTC

And this could be related to bug #152126

Comment 3 squan 2008-12-20 13:22:41 UTC

Hint: dropping things on tabs or works.
And dropping right behind a tab opens a new tab!
This is a nice additional feature.
But of of course the main window should also accept drops.

Comment 4 Frank Reininghaus 2008-12-22 01:46:51 UTC

I think that the commit which added the new find bar caused this regression:

http://websvn.kde.org/?view=rev&revision=884889

At least dropping URLs works for me in 884888 while it doesn't in 884889. I'm CC'ing Germain because he committed it.

Since then, KHTMLPart::init( KHTMLView *view,...) does not set the 'view' as its main widget with setWidget(), but a layout consisting of the KHTMLView and the find bar. It appears that the mouse drop event is not forwarded from the layout to the view for some reason.

I've verified that calling 'setWidget(view)' makes dropping URLs work again in rev. 900020, but of course, that destroys the find functionality.

Comment 5 David Faure 2009-02-23 20:18:32 UTC

SVN commit 930536 by dfaure:

Repair DND-onto-khtmlview -- the part's widget isn't a qscrollarea anymore since the findbar redesign,
so we need to call setAcceptDrops explicitely on the part's widget.
BUG: 177925


 M  +2 -0      konqview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=930536