Bug 177856

Summary:	move "switch application language" from "help" to "settings"
Product:	[Frameworks and Libraries] frameworks-kxmlgui	Reporter:	Maciej Pilichowski <bluedzins>
Component:	general	Assignee:	Nate Graham <nate>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	aspotashev, bugseforuns, frederic.chaume, jjm, nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:	https://invent.kde.org/frameworks/kxmlgui/commit/a957f121882469596330f2afb25e95c9943b1c34	Version Fixed In:	5.72

Description Maciej Pilichowski 2008-12-15 15:56:30 UTC

Version:            (using KDE 4.1.3)
Installed from:    SuSE RPMs

move "switch application language" from "help" to "settings"

Because it has nothing (completely nothing) to do with help in any way -- it belongs to configuring application, thus settings.

Comment 1 Andrew Crouthamel 2018-11-02 04:22:17 UTC

Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!

Comment 2 Jonathan Marten 2018-11-03 12:33:04 UTC

Still relevant (and IMHO a worthwhile change) for KDE Frameworks 5.  Reassigned to KXmlGui product and marking as wishlist.

Comment 3 Thomas Friedrichsmeier 2020-06-09 19:35:59 UTC

*** Bug 398252 has been marked as a duplicate of this bug. ***

Comment 4 Nate Graham 2020-06-09 22:42:47 UTC

Dunno why I didn't do this years ago. ago Here's merge request that will fix it: https://invent.kde.org/frameworks/kxmlgui/-/merge_requests/4

Comment 5 Nate Graham 2020-06-19 16:15:25 UTC

Git commit a957f121882469596330f2afb25e95c9943b1c34 by Nate Graham.
Committed on 19/06/2020 at 16:15.
Pushed by ngraham into branch 'master'.

Move "Switch Application Language" to Settings menu

This is where it logically belongs. Applications with only a Help menu
and no settings menu will still get it displayed in there due to some
fancy code in khelpmenu.cpp, so there are no cases where the menu item
will become completely inaccessible.

Test Plan:
1. Open Okular, Konsole, or Dolphin with its menu bar shown
2. Look in Settings and Help menus to make sure the action is in the
   Settings menu

1. Open an app without a visible Settings menu such as Spectacle or
   Dolphin with its menubar hidden
2. Look in the help menu to make sure the action is shown there
FIXED-IN: 5.72

M  +1    -1    src/kswitchlanguagedialog_p.cpp
M  +2    -3    src/ui_standards.rc

https://invent.kde.org/frameworks/kxmlgui/commit/a957f121882469596330f2afb25e95c9943b1c34