Summary: | Skip length (cursor left or right) is fixed to 10 seconds | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Lars Müller <lmuelle> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | darthcodus, dmeltzer.devel, hamboy95, matwey.kornilov, ralf-engels, spam.me.now.yeah |
Priority: | HI | Keywords: | junior-jobs |
Version: | 2.6-git | ||
Target Milestone: | 2.8 | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/amarok/265696b694559e09cad34f4b5e06077b92f91dce | Version Fixed In: | 2.8 |
Sentry Crash Report: | |||
Attachments: | Sample playback config UI file with settings for VLC style jumps |
Description
Lars Müller
2008-12-08 21:26:01 UTC
I'm thinking that if we made the modifier + arrow scroll in one second increments it would work fairly appropriately. I'll look into this for 2.1 Would this require to press the key combination five times to skip five seconds? I fear this isn't very user friendly in the particular use case as you have to skip back very often. I would prefer a configuration option. Not a very prominent one. But one which allows to define an individual gap. In reality not all Phonon backends may be able to seek with the same precision. Something to look into too. This 10 second skip still happens in Amarok 2.5, and since it was filed 3 years ago, is this still necessary to be implemented? Moving to bugs, this hard-coded time span should really be revised. Indeed, this should be removed ASAP. *** Bug 284682 has been marked as a duplicate of this bug. *** That is a low hanging fruit. Do you want: - Key modifier (I would use the same order as the vlc default modifiers shift, alt, control) - Configuration option -- Option also visible in configuration dialog (this needs new text so it would be out of scope for 2.7) -- Hidden option (hidden meaning we have the option but it's not visible in the configuration dialog) Any other clever idea? Setting status correctly. This is marked now as a Junior Job. I'm interested in solving this bug. Could someone please guide me through this? (In reply to comment #10) > I'm interested in solving this bug. Could someone please guide me through > this? Nice to hear :) Please read through the documents listed here: http://community.kde.org/Amarok/Development/Join and install a local build of Amarok from git (all in the links) before getting in touch with us in #amarok on irc.freenode.net Done all of that, heading to IRC... Using this account on bugzilla from now on instead of spam.me.now.yeah Created attachment 77286 [details]
Sample playback config UI file with settings for VLC style jumps
How should I go about implementing this? Do I implement VLC style jumps, with 4 different durations? If so, what key mapping do I choose, the same as VLC? I'm not so sure about the alt+ctrl+l/r combination, I believe it's the Unity default for moving between workspaces. Is the attached config dialog okay? (In reply to comment #15) > How should I go about implementing this? Do I implement VLC style jumps, > with 4 different durations? If so, what key mapping do I choose, the same as > VLC? I'm not so sure about the alt+ctrl+l/r combination, I believe it's the > Unity default for moving between workspaces. > > Is the attached config dialog okay? I thought that I made this clear in my mail: please ask this in the amarok-devel@mailing list and use reviewboard for proposed patches, even if those are still in an early stage. Git commit 265696b694559e09cad34f4b5e06077b92f91dce by Matěj Laitl, on behalf of Anmol Ahuja. Committed on 20/02/2013 at 22:04. Pushed by laitl into branch 'master'. Add 2 more variants of seeking shortcuts + hidden config options Control + L/R - Short seek L/R - Normal/ Medium seek Shift + L/R - Long seek Along this the "Go Up in Media Sources Pane" gets renamed and reassigned to Backspace. FEATURES: * Added keyboard shortcuts for small 2 s seeks (Ctrl + Left/Right) and long 1 minute seeks (Shift + Left/Right) in addition to standard 10 s seeks. Durations are now configurable in amarokrc, see Amarok Handbook. Patch by Anmol Ahuja. @Anmol, you may want to check minor changes I made to the patch. REVIEW: 108964 FIXED-IN: 2.8 CCMAIL: Anmol Ahuja <darthcodus@gmail.com> M +3 -0 ChangeLog M +75 -6 src/MainWindow.cpp M +7 -0 src/MainWindow.h M +17 -2 src/amarokconfig.kcfg M +2 -2 src/browsers/BrowserDock.cpp http://commits.kde.org/amarok/265696b694559e09cad34f4b5e06077b92f91dce |